<optional>: Remove stale LWG-3627 comments - #6416
Open
zika (tycket033-tech) wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes stale LWG-3627 comments after its resolution was implemented in #2607. No behavior changes.
Changes:
- Removed two obsolete LWG-3627 annotations from
<optional>and its compile test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
stl/inc/optional |
Removes the stale annotation from make_optional. |
tests/std/tests/GH_002299_implicit_sfinae_constraints/test.compile.pass.cpp |
Removes the stale annotation from the existing assertion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
@microsoft-github-policy-service agree |
Contributor
Thanks. Although I think it would be faster to just search the comments using editor without AI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resolution for LWG-3627 was already implemented in #2607, so the remaining
comments are no longer needed.
This PR removes the two stale
LWG-3627comments from<optional>and itstest. There are no behavior changes.
No tests were run because this is a comment-only change.
Fixes #5851.
AI assistance: I used Codex to find the comments and help prepare this PR.
I've reviewed and understand the change.