Repository navigation
Fix imageConfig being dropped by MarkdownRenderConfig builders - #179
Open
Vincent Peng (vincent-peng) wants to merge 1 commit into
Open
Vincent Peng (vincent-peng) wants to merge 1 commit into
Vincent Peng (vincent-peng) wants to merge 1 commit into
Conversation
Every withXxx builder except withImageConfig omitted the imageConfig parameter, silently resetting it to .disabled whenever a consumer customized any other config field after enabling images. Forward the existing value so builders compose correctly. Refs microsoft#173 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Vincent Peng (vincent-peng)
requested review from
a team
and
a balanced review from Copilot
October 8, 2026 13:41
This was referenced Oct 8, 2026
Contributor
Author
|
Independent verification: PASS (verified against the real artifact by an agent that did not write the code, on detached worktree
|
Vincent Peng (vincent-peng)
added a commit
to vincent-peng/SwiftStreamingMarkdown
that referenced
this pull request
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every
with…builder onMarkdownRenderConfigconstructs a fresh config and is responsible for forwarding each field. Six builders were missingimageConfig:in the forwarded initializer, so chaining them after.withImageConfig(...)silently reset the image configuration to.default(disabled).This change forwards
imageConfigin the builders that were missing it. Issue #173 tracks the broader builder-API redesign; this keeps the diff to the minimal bug fix.Validation
make lint— 0 violations (strict)make test— full package suite passes, including a newMarkdownRenderConfigBuilderTestssuite asserting everywith…builder preservesimageConfigOSS readiness
with…builders.Refs #173