Fix "Cancel" button in the C# and C++ wapproj templates so that it returns to the "Configure your new project" menu instead of creating a broken project - #6708
Open
Lauren Ciha (lauren-ciha) wants to merge 12 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Lauren Ciha (lauren-ciha)
requested review from
Dinah Xiaoman G (DinahK-2SO) and
Scott Jones (Scottj1s)
and
a lite review from Copilot
and removed request for
Copilot
August 21, 2026 23:17
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. |
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. |
…uildToolsWinAppVersion to {name}$ (parent template parameter) instead of project template parameter
…e to the PackagedApp.vstemplate
…plate to the PackagedApp.vstemplate
Lauren Ciha (lauren-ciha)
force-pushed
the
user/laurenciha/fix-wapproj-cancel-button
branch
from
August 26, 2026 17:44
464eb00 to
f7ea7df
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Moves platform-version dialogs to packaged-app parent templates so cancellation aborts the entire project group.
Changes:
- Propagates parent wizard parameters into C# and C++ child projects.
- Adds MSBuild-version selection and VSIX validation.
- Adds local Windows App SDK version resolution.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
Build-VSIX-Local.ps1 |
Adds MSBuild selection and VSIX checks. |
build-install-localdev-vsix.ps1 |
Forwards the MSBuild version. |
WinUI.Desktop.Cs.PackagedApp.vstemplate |
Moves the platform wizard to the parent. |
WinUI.Desktop.Cs.WapProj.vstemplate |
Removes the child platform wizard. |
C# WapProjTemplate.wapproj |
Uses propagated platform parameters. |
C# BlankApp/ProjectTemplate.csproj |
Uses propagated package versions. |
WinUI.Desktop.CppWinRT.PackagedApp.vstemplate |
Moves platform and publisher wizards. |
WinUI.Desktop.CppWinRT.WapProj.vstemplate |
Removes moved child wizards. |
C++ WapProjTemplate.wapproj |
Uses propagated platform parameters. |
C++ Package-managed.appxmanifest |
Uses the propagated publisher. |
Test-DotnetNewTemplates.ps1 |
Adds local package-version lookup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. |
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the WinUI Blank App (Packaged with Windows Application Packaging Project) templates for C# and C++, a dialog appears asking users to confirm target and minimum platform versions they want their app to support:
Before this change, when a user clicked "Cancel", the template would generate the BlankApp project, but not the packaging (wapproj) project. This was because the wizard that launched this dialog only existed in the packaging project and not the parent project (an invisible project that configures the entire template). By moving the dialog into the parent project, both projects exit when "Cancel" is clicked, returning users to the "Configure your new project menu" to edit their app settings further.
Locally validated the fix and confirmed there were no regression by manually testing with the local builds (
dev\Templates\VSIX\build-local-VSIX-package\build-install-localdev-vsix.ps1).A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.