[Quim Muntal (qmuntal)]

Summary

• Add backend-neutral tool tracing through toolautocall.Config.Tracer and toolautocall.WithTracer, with explicit configuration taking precedence.
• Move tool spans into otelprovider, preserving automatic middleware injection and adding NewToolTracer for explicit use.
• Move the shared error-type helper into internal/telemetry and remove internal/otelx.

This removes OpenTelemetry from the core, OpenAI provider, and workflow build dependencies. Provider SDKs may still depend on OpenTelemetry; module requirements are unchanged.

Validation

• Focused Go tests pass for automatic tool calling, harness integration, the OTel provider, telemetry, and workflow observability.
• Changed-file lint: 0 issues.
• Verified the OpenTelemetry-free core dependency graph.

[Copilot]

🟢 Approval recommended

The backend-neutral tool-tracing refactor has no active review issues.

No open issues 🎉

What changed in this PR

Decouples automatic tool tracing from OpenTelemetry, keeping backend-specific span handling in otelprovider while preserving automatic middleware injection.

Changes:

• Adds a backend-neutral tracer interface and context injection, with explicit configuration taking precedence.
• Moves tool spans into otelprovider and the shared error-type helper into internal/telemetry, removing internal/otelx.
• Expands tests for tracer selection, streaming, concurrency, errors, panics, and cancellation.

File	Description
workflow/​internal/​observability/​observability.go	Uses the relocated error-type helper.
provider/​otelprovider/​tool.go	Implements OpenTelemetry tool tracing and NewToolTracer.
provider/​otelprovider/​otel.go	Injects the backend-neutral tool tracer.
provider/​otelprovider/​otel_test.go	Expands tool-span configuration and failure tests.
provider/​otelprovider/​model.go	Uses the relocated error-type helper.
provider/​otelprovider/​embedding.go	Uses the relocated error-type helper.
provider/​otelprovider/​doc.go	Documents explicit tool tracing.
internal/​telemetry/​telemetry.go	Adds the shared error-type helper.
internal/​telemetry/​telemetry_test.go	Tests error-type naming behavior.
internal/​otelx/​error.go	Removes the relocated helper.
internal/​otelx/​context.go	Removes OpenTelemetry-specific tracer context storage.
agent/​harness/​toolautocall/​doc.go	Documents backend-neutral tracing and precedence.
agent/​harness/​toolautocall/​autocall.go	Replaces direct OpenTelemetry usage with tracer callbacks.
agent/​harness/​toolautocall/​autocall_test.go	Tests tracer lifecycle, precedence, and concurrent calls.

_{Review effort: Balanced}

[github-actions]

API consistency review

Result	Scope
unable to determine	public API, user-visible behavior

Changed Go contract

• New exported toolautocall.Config.Tracer and toolautocall.WithTracer. An explicit tracer takes precedence over the context tracer.
• New otelprovider.NewToolTracer. Tool spans are now created in otelprovider instead of the core.
• Automatic middleware injection of tool spans is preserved.
• internal/otelx is removed.

Upstream evidence reviewed

No upstream evidence was gathered in this run. I did not compare against the .NET or Python tool-invocation telemetry. The PR's validation covers Go tests only.

Assessment

I could not complete the comparison, so I am not approving parity and have no confirmed findings. The new Tracer hook looks like Go-specific plumbing. It exists to remove OpenTelemetry from the core dependency graph. The .NET OpenTelemetryAgent and FunctionInvokingChatClient path and the Python observability.py do not obviously expose an equivalent option. Maintainers should check that the span names, attributes and default-on behavior of tool tracing match .NET and Python. Those are the observable parts of the change.

Generated by Go API Consistency Review Agent for #1342 · copilot · auto · 18.2 AIC · ⌖ 0.616 AIC · ⊞ 4.9K · ◷