Repository navigation
shelltool: remove shared test timeout - #1353
Merged
Merged
Conversation
Remove the helper's unrelated 20-second per-command deadline from the persistent shell behavioral tests. Keep explicit deadlines in timeout-specific tests and rely on the overall go test timeout to catch hangs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change removing the shared timeout from persistent shell tests.
No open issues 🎉
What changed in this PR
Removes the shared per-command deadline from persistent shell behavioral tests to avoid unrelated timeout failures, including the reported PowerShell exit-code test failure.
Changes:
- Removes the 20-second timeout from
persistentPlatformConfig. - Leaves timeout-specific tests’ explicit limits and the overall
go testtimeout unchanged.
| File | Description |
|---|---|
tool/shelltool/shelltool_test.go |
Removes the shared timeout from the persistent shell test configuration. |
Review effort: Balanced
Quim Muntal (qmuntal)
enabled auto-merge
November 4, 2026 06:28
George Adams (gdams)
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the shared 20-second per-command deadline from the persistent shell behavioral tests. Timeout-specific tests keep their explicit limits, and the overall
go testtimeout still bounds the suite.This removes the unrelated deadline hit by the PowerShell exit-code test in https://github.com/microsoft/agent-framework-go/actions/runs/41782292794. No data race was reported or reproduced.
Validation: the full shelltool package passed on Windows/amd64 with
-raceand CI shuffle seed1793772092443344900, including a fresh run on this main-based branch.