Skip to content

Python: fix(core): handle None text and Mapping arguments in Content addition - #8689

Closed
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
microsoft:mainfrom
ManoharPaturi:fix/content-add-robustness
Closed

Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
microsoft:mainfrom
ManoharPaturi:fix/content-add-robustness

Conversation

@ManoharPaturi

Copy link
Copy Markdown
Contributor

While working with streaming chunks and combining Content instances, I noticed that Content._add_text_content throws a TypeError if either instance has text=None because of direct self.text + other.text addition. In contrast, _add_text_reasoning_content already handles None text values safely by falling back to empty strings and preserving None when both sides are None.

In addition, _add_function_call_content was checking isinstance(..., dict) rather than isinstance(..., Mapping), which rejects valid mapping implementations like MappingProxyType even though the type hints explicitly allow Mapping[str, Any].

This PR updates _add_text_content to handle None text values gracefully and widens the function call arguments check to Mapping. I also added unit tests covering both cases in test_types.py.

Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot changed the title fix(core): handle None text and Mapping arguments in Content addition Python: fix(core): handle None text and Mapping arguments in Content addition Sep 23, 2026
@eavanvalkenburg

Copy link
Copy Markdown
Member

Thank you for proposing this change. I am closing this PR for now because it has no linked issue, and I could not find an issue covering this specific problem. Our contribution guidelines ask contributors to create or reuse an issue and discuss the approach before nontrivial changes (with an exception for trivial changes). The repository PR template asks for Motivation & Context, Description & Review Guide, a Related Issue linked with a closing keyword such as Fixes #123, and the contribution checklist; it notes that PRs without an issue link may be closed. This description does not follow that template. Please open or identify an issue, agree on the approach with the maintainers, then submit an updated PR using the template and linking the issue. Thanks.

This branch was previously deployed

1 inactive deployment
github-app-auth — cd6d41e7 Deployed Sep 23, 2026 by ManoharPaturi via team_check #5160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Usage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants