Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions python/packages/core/agent_framework/_agents.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from __future__ import annotations

import keyword
import logging
import re
import sys
Expand Down Expand Up @@ -248,6 +249,10 @@ def _sanitize_agent_name(agent_name: str | None) -> str | None:
if sanitized and sanitized[0].isdigit():
sanitized = f"_{sanitized}"

# Suffix with underscore if the sanitized name is a reserved Python keyword
if keyword.iskeyword(sanitized):
sanitized = f"{sanitized}_"

return sanitized


Expand Down
10 changes: 10 additions & 0 deletions python/packages/core/tests/core/test_agents.py
Original file line number Diff line number Diff line change
Expand Up @@ -3458,6 +3458,16 @@ def test_sanitize_agent_name_replaces_invalid_chars():
assert "!" not in result # type: ignore[operator] # pyrefly: ignore[not-iterable] # ty: ignore[unsupported-operator]


def test_sanitize_agent_name_handles_python_keywords():
"""Test _sanitize_agent_name appends trailing underscore for Python keywords."""
assert _sanitize_agent_name("for") == "for_"
assert _sanitize_agent_name("def") == "def_"
assert _sanitize_agent_name("class") == "class_"
assert _sanitize_agent_name("return") == "return_"
assert _sanitize_agent_name("import") == "import_"
assert _sanitize_agent_name("pass") == "pass_"


# endregion


Expand Down
Loading