Skip to content

Python: fix(core): reject booleans and non-integers for FunctionTool invocation limits - #8696

Closed
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
microsoft:mainfrom
ManoharPaturi:fix/function-tool-invocation-limits-validation
Closed

Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
microsoft:mainfrom
ManoharPaturi:fix/function-tool-invocation-limits-validation

Conversation

@ManoharPaturi

Copy link
Copy Markdown
Contributor

In FunctionTool.init, max_invocations and max_invocation_exceptions were only validated with a less-than-1 comparison. Because bool is a subclass of int in Python, passing True bypassed the check because True is not less than 1, causing the limit to be silently set to 1. Passing False resulted in an unclear error message rather than rejecting the boolean type. Non-integers like floats or strings were also not rejected upfront.

This PR updates FunctionTool.init so that provided limits must be non-boolean integers of at least 1. I also added unit tests in test_tools.py verifying both the type validation and invocation limit enforcement.

…on limits

Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@agent-framework-automation agent-framework-automation Bot added the python Usage: [Issues, PRs], Target: Python label Sep 23, 2026
@github-actions github-actions Bot changed the title fix(core): reject booleans and non-integers for FunctionTool invocation limits Python: fix(core): reject booleans and non-integers for FunctionTool invocation limits Sep 23, 2026
@eavanvalkenburg

Copy link
Copy Markdown
Member

Thank you for proposing this change. I am closing this PR for now because it has no linked issue, and I could not find an issue covering this specific problem. Our contribution guidelines ask contributors to create or reuse an issue and discuss the approach before nontrivial changes (with an exception for trivial changes). The repository PR template asks for Motivation & Context, Description & Review Guide, a Related Issue linked with a closing keyword such as Fixes #123, and the contribution checklist; it notes that PRs without an issue link may be closed. This description does not follow that template. Please open or identify an issue, agree on the approach with the maintainers, then submit an updated PR using the template and linking the issue. Thanks.

This branch was previously deployed

1 inactive deployment
github-app-auth — 912edf67 Deployed Sep 23, 2026 by ManoharPaturi via team_check #5167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Usage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants