Repository navigation
Python: fix(core): leave out description for MCP prompt arguments that have none - #8733
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit intoSep 29, 2026
Conversation
Anish Mehta (anishmehta24)
temporarily deployed
to
github-app-auth
September 24, 2026 17:14 — with
GitHub Actions
Inactive
Anish Mehta (anishmehta24)
temporarily deployed
to
github-app-auth
September 24, 2026 17:14 — with
GitHub Actions
Inactive
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Sep 29, 2026
Eduard van Valkenburg (eavanvalkenburg)
left a comment
Member
There was a problem hiding this comment.
Anish Mehta (@anishmehta24) Reviewed the current head and found no blocking issues.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
_get_input_model_from_mcp_promptbuilds the argument schema withprompt_argument.description if hasattr(prompt_argument, "description") else "".PromptArgumentalways has the attribute (it's an optional pydantic field), so an argument without a description comes through asNone:descriptionhas to be a string in JSON Schema, so a provider that validates tool schemas strictly can reject the tool.Description & Review Guide
descriptiononly when the argument has one."", since an empty description adds nothing.Related Issue
No existing issue.
Contribution Checklist
Test:
test_get_input_model_from_mcp_prompt_argument_without_descriptionintests/core/test_mcp.py; it fails on main.pytest packages/core/tests/core/test_mcp.pypasses, and ruff and the repo's pre-commit checks are clean.