Repository navigation
Python: fix(providers): send a single stop string as a list in Gemini, Bedrock, Anthropic and Ollama - #8736
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit intoSep 28, 2026
Conversation
…, Bedrock, Anthropic and Ollama
Anish Mehta (anishmehta24)
temporarily deployed
to
github-app-auth
September 24, 2026 17:36 — with
GitHub Actions
Inactive
Anish Mehta (anishmehta24)
temporarily deployed
to
github-app-auth
September 24, 2026 17:36 — with
GitHub Actions
Inactive
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Sep 28, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
ChatOptions.stopis typedstr | Sequence[str], but four providers pass a single string straight into a field that only takes a list:stop_sequencesfailsGenerateContentConfigvalidation ("Input should be a valid list").inferenceConfig.stopSequences("valid types: list, tuple").stop_sequences: "END"; the API expects an array.options.stop: "END"; Ollama expects a list.OpenAI and Mistral accept a string, so they're unchanged.
Description & Review Guide
stopto its provider field, a plain string is wrapped in a one-item list. Lists are passed as before.options={"stop": "END"}works on these providers instead of failing or sending the wrong type.Related Issue
No existing issue.
Contribution Checklist
One test per provider for a single stop string (all four fail on main). The gemini, bedrock, anthropic and ollama test suites pass, and the repo's pre-commit checks are clean.