Repository navigation
Python: coerce Magentic max round count below one up to one - #9502
Manohar Paturi (ManoharPaturi) wants to merge 3 commits into
Conversation
Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
Eduard van Valkenburg (eavanvalkenburg)
left a comment
There was a problem hiding this comment.
The change restores the BaseGroupChatOrchestrator round-limit contract before Magentic's first limits check, and the regression demonstrates that one coordination round runs instead of terminating immediately.
…cepts it Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
|
The The job crashes inside griffe while loading the base (main) snapshot, before it compares the PR changes — the traceback points at the base copy of the package: Example run: https://github.com/microsoft/agent-framework/actions/runs/39810016173/job/119933441343 None of the changes in this PR touch |
|
Eduard van Valkenburg (@eavanvalkenburg) the failing Public API Compatibility check was the repo wide griffe crash on the base snapshot, and that is fixed on main now: every API compat run since, including four on my other PRs today, passes. 9798ecf merges current main so the check re-runs against the healthy base, and the branch was out of date anyway. The magentic suite still passes locally (58 tests). The only thing left is a re-approval, since your earlier one went stale when the typing fix landed after it. |
Motivation & Context
The base group chat contract says a max round count below 1 is coerced to 1. Magentic assigns its round limit from
manager.max_round_countaftersuper().__init__, which bypasses that rule, so a limit of 0 ends the workflow at the first limits check before any coordination round or participant turn happens.Description & Review Guide
GroupChatOrchestrator. Values of 1 or higher andNonebehave as before.Related Issue
Fixes #9500
AI Assistance