Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/packages/devui/agent_framework_devui/_mapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -1432,7 +1432,7 @@ async def _map_reasoning_content(self, content: Any, context: dict[str, Any]) ->
"""Map TextReasoningContent to ResponseReasoningTextDeltaEvent."""
return ResponseReasoningTextDeltaEvent(
type="response.reasoning_text.delta",
delta=content.text,
delta=content.text or "",
item_id=context["item_id"],
output_index=context["output_index"],
content_index=context["content_index"],
Expand Down
24 changes: 24 additions & 0 deletions python/packages/devui/tests/devui/test_mapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,30 @@ async def test_text_content_mapping(mapper: MessageMapper, test_request: AgentFr
assert events[2].delta == "Hello, clean test!"


@pytest.mark.parametrize(("reasoning_text", "expected_delta"), [(None, ""), ("", ""), ("Thinking...", "Thinking...")])
async def test_reasoning_content_mapping_handles_missing_text(
mapper: MessageMapper,
test_request: AgentFrameworkRequest,
caplog: pytest.LogCaptureFixture,
reasoning_text: str | None,
expected_delta: str,
) -> None:
"""Missing reasoning text must not emit an error or discard the following answer."""
update = create_test_agent_update([
Content.from_text_reasoning(text=reasoning_text),
Content.from_text(text="Final answer."),
])

events = await mapper.convert_event(update, test_request)

assert all(event.type != "error" for event in events)
reasoning_events = [event for event in events if event.type == "response.reasoning_text.delta"]
assert len(reasoning_events) == 1
assert reasoning_events[0].delta == expected_delta
assert any(event.type == "response.output_text.delta" and event.delta == "Final answer." for event in events)
assert "Error converting agent update" not in caplog.text


async def test_marked_refusal_text_mapping(mapper: MessageMapper, test_request: AgentFrameworkRequest) -> None:
content = Content.from_text(
"I cannot help.",
Expand Down
Loading