Repository navigation
Python: Fix Purview guide credential setup - #9553
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit intoOct 22, 2026
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both documentation corrections match the existing implementation, with no unresolved findings.
No open issues 🎉
What changed in this PR
Corrects the Purview package guide to match the existing API without changing runtime code.
Changes:
- Supplies
DefaultAzureCredential()to the middleware constructor. - Describes
PurviewSettingsas aTypedDict.
| File | Description |
|---|---|
| python/packages/purview/AGENTS.md | Corrects credential setup and settings-type documentation. |
Review effort: Balanced
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Oct 22, 2026
Eduard van Valkenburg (eavanvalkenburg)
left a comment
Member
There was a problem hiding this comment.
The guide now matches the existing Purview API: PurviewPolicyMiddleware receives the required credential, and PurviewSettings is accurately described as a TypedDict.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
The Purview package guide illustrates
PurviewPolicyMiddleware(settings=settings), but the constructor requires a credential as well. It also describesPurviewSettingsas Pydantic settings although the current type is aTypedDict.Description & Review Guide
DefaultAzureCredential()to the illustrated constructor and describe the settings type accurately. The existing ellipses remain application-specific placeholders.Related Issue
N/A - trivial change: correct an existing documentation example to supply an already-required parameter and fix its settings-type description. No API or runtime change.
AI Assistance
AI assistance details: Documentation, local verification, and PR description.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after a language prefix such asPython:or.NET:) — a workflow keeps the label and title prefix in sync automatically.