Repository navigation
Python: fix(lab-gaia): accept local parquet data in _ensure_data - #9609
Open
Manohar Paturi (ManoharPaturi) wants to merge 7 commits into
Open
Manohar Paturi (ManoharPaturi) wants to merge 7 commits into
Manohar Paturi (ManoharPaturi) wants to merge 7 commits into
Conversation
_ensure_data only recognized the old metadata.jsonl layout, so a data dir holding only the parquet files the loader itself prefers was ignored and the runner demanded HF_TOKEN for a fresh download. Accept metadata*.parquet in the same existence check. Fixes microsoft#9337 Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
…ing local data A partial metadata-XXXXX-of-NNNNN family from an interrupted copy would have counted as ready and run the benchmark over a truncated task set. Group shards by directory and prefix and only treat the snapshot as complete when each group holds all its declared shards. Follow-up to the review on microsoft#9340. Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
… fix/gaia-parquet-ensure-data
An unsharded metadata parquet made the completeness check return early, so a directory mixing a plain file with an incomplete sharded family was treated as ready. Keep scanning after unsharded files and let any incomplete family disqualify the directory. Also clear HF_TOKEN in the incomplete snapshot test so it cannot attempt a real download. Follow-up to the review on microsoft#9340. Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
… is present Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
Manohar Paturi (ManoharPaturi)
requested review from
SergeyMenshykh,
Tao Chen (TaoChenOSU),
Eduard van Valkenburg (eavanvalkenburg),
Giles Odigwe (giles17),
Jose Alvarez (jpalvarezl),
Evan Mattson (moonbox3),
Roger Barreto (rogerbarreto),
sophia-ramsey and
westey (westey-m)
as code owners
October 22, 2026 15:59
Manohar Paturi (ManoharPaturi)
deployed
to
github-app-auth
October 22, 2026 15:59 — with
GitHub Actions
Active
Manohar Paturi (ManoharPaturi)
deployed
to
github-app-auth
October 22, 2026 15:59 — with
GitHub Actions
Active
Manohar Paturi (ManoharPaturi)
deployed
to
github-app-auth
October 22, 2026 15:59 — with
GitHub Actions
Active
Manohar Paturi (ManoharPaturi)
deployed
to
github-app-auth
October 22, 2026 16:01 — with
GitHub Actions
Active
Manohar Paturi (ManoharPaturi)
deployed
to
github-app-auth
October 22, 2026 16:01 — with
GitHub Actions
Active
1 task done
Contributor
Author
|
The The job crashes inside griffe while loading the base (main) snapshot, before it compares the PR changes — the traceback points at the base copy of the package: Example run: https://github.com/microsoft/agent-framework/actions/runs/39810016173/job/119933441343 None of the changes in this PR touch |
Manohar Paturi (ManoharPaturi)
deployed
to
github-app-auth
October 22, 2026 16:04 — with
GitHub Actions
Active
6 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
_load_gaia_localprefers parquet files (the comment calls it the new format, validation split first) butGAIA._ensure_dataonly treated a data dir as ready when it containedmetadata.jsonl. Pointingdata_dirat a parquet-only mirror was ignored and the runner demanded HF_TOKEN for a fresh download even though the local data was fully usable. Issue #9337 has the repro.This PR replaces #9340, which was closed while it still had outstanding review feedback:
_ensure_data()still returned successfully whenever anymetadata.jsonlexisted, without checking incomplete parquet shards in the same directory. Per the close reason, it is being resubmitted here with that feedback addressed on top of the original fix.Description & Review Guide
_ensure_datanow accepts a data dir through_has_usable_local_data(): if anymetadata*.parquetfile is present (the same glob the loader itself reads), the parquet snapshot must be complete; otherwise the dir is usable whenmetadata.jsonlis present. A JSONL-only layout keeps working exactly as before.metadata-XXXXX-of-NNNNN.parquetfamily) no longer silently passes. The loader reads parquet first and only falls back to JSONL when no parquet file is present, so such a mixed dir would have loaded a truncated task set without any error — this is the review feedback from Python: fix(lab-gaia): accept local parquet data in _ensure_data #9340, addressed by requiring a complete parquet snapshot whenever any metadata parquet file is present._has_usable_local_datahelper ingaia.py, plus the two new regression tests:test_jsonl_does_not_rescue_an_incomplete_parquet_family(mixed layout with shard 0 of 2 forces download; completing the family makes the dir ready again) andtest_jsonl_only_layout_is_still_accepted.The full GAIA suite (9 tests), Ruff (pinned 0.16.10) check/format, pyright, and mypy are clean locally.
Related Issue
Fixes #9337
AI Assistance
Contribution Checklist