Repository navigation
feat: show a concise checklist by default in doctor - #382
Merged
Merged
Conversation
Show a short fixed-copy checklist by default and retain the original technical report with --verbose. Keep diagnostic collection, JSON output, and exit codes unchanged. Extend safety, installed-wheel, entry-point, and completion coverage. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the roughly 90-line default technical report from
amplifier doctorwith a short checklist for people. The checklist distinguishes settings-read status from collection limits, treats absent optional settings as optional, and states that AI connections and running sessions were not tested. It does not claim that Amplifier is healthy or working. It gives a clear next step: describe the problem and ask for the CLI doctor agent.--verboseretains the original technical report. JSON remains unchanged, including when combined with--verbose. This is a presentation-only follow-up to #380: no settings changes, repairs, new network activation, automatic probes, or model calls.Example
Synthetic example; no host details:
Compatibility and verification
The collector and original technical renderer are byte-identical to the base. JSON schema, collection behavior, privacy boundaries, startup dispatch, ownership enforcement, agent, and skill are unchanged. JSON takes precedence over
--verbose; output is byte-identical with and without that flag. Exit codes remain0for complete collection,1for partial/refused collection, and2for invalid arguments.The intentional compatibility change is the default text presentation. Use
--verbosefor the former technical text or--format jsonfor structured consumers. Neither collection completion nor a readable settings file establishes effective configuration or live health.Local verification before the Windows-newline test follow-up:
git diff --checkpassed. Independent read-only source/privacy/UX review passed across all seven changed files. Public examples and fixtures are synthetic. No full type-check gate or universal health claim is asserted.false, not an all-process zero-attempt pass. Python bootstrap attempted denied bytecode-cache writes before first package access: three per console route and 15 for the legacy module, matching same-interpreterpython -c/python -mcontrols in paths and counts. No application-owned writes, network calls, subprocess spawns, or persistent changes were observed; each process had one initial exec. Interpreter startup remains outside the application passivity guarantee.To verify, run the doctor, entry-point, agent, and shell-completion tests; run the full suite and POSIX integration selection; and run the installed-wheel check through the existing CI workflow. Compare default text,
--verbose, JSON with and without--verbose, and complete/partial/refused exit codes.Windows newline follow-up
The original CI run reported four doctor JSON assertion failures in each Windows job: Click captured native CRLF, while the tests expected LF. This test-only follow-up uses
os.linesepand explicit UTF-8 encoding in the two existing tests. The same complete/partial/refused cases, exit-code checks, and exact expected JSON content remain; explicit byte-for-byte parity with and without--verboseis also asserted. No production code changed. Local static checks and an isolated Click 8.3.1 capture smoke passed; they are not Windows execution proof.Final verification
Remote CI run 40348471733 passed on revised head
e136d9a063a2af2fda4aad53b14a17f4cb568f12: all eight jobs succeeded, covering Ubuntu, macOS, and Windows on Python 3.11/3.12 and both POSIX integration jobs. The Ubuntu/Python 3.11 installed-wheel and generated legacy-launcher step also succeeded. The CLA check passed on the same head. Both Windows jobs passed with the native-newline assertions; no production code or CI exclusions were added by that follow-up.Local verification used Linux ARM64/Python 3.11 and is not Windows or macOS proof. The historical local-suite and interpreter-bootstrap limitations above remain unchanged. The agent and skill are unchanged; this presentation-only change makes no new live-model reliability claim.