Repository navigation
fix: keep incomplete resume cost warnings compact - #383
Merged
Merged
Conversation
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change makes incomplete fork-resume cost reporting compact and avoids implying that missing history means zero cost.
Warning: historical cost is incomplete. Available amounts are a partial subtotal.Warning: complete historical cost is unavailable. Do not treat missing cost as zero.SessionConfig.verboseis enabled. The existingamplifier run --resume <id> --verboseroute provides that detail; this change does not add or promise a shorthand flag.The commit is based directly on current
main(b7e533a49ab3b155098caa68b4f3c5b7001d0482). It contains one commit and exactly four files:AGENTS.md,amplifier_app_cli/session_runner.py,docs/warm-shared-root-state.md, andtests/test_session_runner.py. The added and removed source lines match the previously reviewed four-file patch; current-main transcript-repair, doctor, provider-source, dependency, and guidance changes are retained. No unrelated old-branch commits are included.Verification
tests/test_session_runner.py,tests/test_cost_history.py, andtests/test_cost_bridge.py.git diff --checkpassed.d1599189fb5dab706a5835c553c183b98f9abc1e: all eight jobs passed in run 40347753582. Thelicense/clapolicy check also passed. The Ubuntu Python 3.11 job included the installed doctor-wheel check.Review scope
Astra (OpenAI gpt-6-astra) and Fable (claude-fable-5-1) reaffirmed approval within the supplied source-excerpt and evidence scope after reviewing the current-main integration and updated whole-file hashes. The reviewed packet covered the implementation, four source bindings, focused test result, and known limits. These were not independent full-source or runtime audits and are not formal GitHub reviews. The approved patch's added and removed lines are identical to the original reviewed patch.
AGENTS.mdSHA256:3987df7c4e81dd56ba4ad7eca8db76206a1ee5d90448f0055263957ccc78fc0eamplifier_app_cli/session_runner.pySHA256:6c88cc41c3b79844fc859f37ad0d840387b9482d3e0192d7a055eda831db2433Compatibility and rollback
The intentional visible change is the warning wording and that detailed warning diagnostics are silent unless verbose mode is enabled. No CLI option, cost-accounting format, or migration is added. Revert this commit to roll back the presentation change; accounting data requires no rollback or migration.