Repository navigation
Reject truncated payloads across all conversion paths - #884
Merged
Brian Caswell (demoray) merged 2 commits intoOct 12, 2026
Merged
Brian Caswell (demoray) merged 2 commits into
Brian Caswell (demoray) merged 2 commits into
Conversation
cduplantisms
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject truncated payloads across all image conversion paths.
#883 identified that a LiME record could declare a larger range than its payload contained. `std::io::copy` returned the number of bytes copied, but the result was ignored, allowing conversion to succeed with zero-padded or incomplete output.
Reviewing the other conversion paths found the same issue in:
Compressed records could also omit or provide an incorrect eight-byte compressed-length trailer. The readers previously skipped the trailer with `seek`, which can succeed beyond EOF.
Changes
This does not change the LiME or compressed AVML wire formats. Valid existing images remain compatible; malformed images that were previously accepted now fail conversion.
Validation