Silence experimental coroutine deprecation - #1619
Draft
Chris Guzak (ChrisGuzak) wants to merge 1 commit into
Draft
Silence experimental coroutine deprecation#1619Chris Guzak (ChrisGuzak) wants to merge 1 commit into
Chris Guzak (ChrisGuzak) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
/await:strict doesn't use experimental coroutines. This seems like the wrong fix? |
Contributor
|
/await works with <experimental/coroutine>, and /await:strict works with <coroutine>. C++20 mode does not require either. |
Member
|
Need a more thorough repro case for what this purports to fix. C++/WinRT no longer includes the deprecated experimental coroutine headers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Define MSVC's opt-out macro for the deprecated <experimental/coroutine> header used by the repository's C++17 /await:strict configuration.
This keeps existing C++17 coroutine builds working with current MSVC toolsets without changing runtime behavior.