test(react-menu): add regression tests for previously fixed issue#36390
Open
PaulGMardling wants to merge 4 commits into
Open
test(react-menu): add regression tests for previously fixed issue#36390PaulGMardling wants to merge 4 commits into
PaulGMardling wants to merge 4 commits into
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -5,6 +5,7 @@ import { useMenuItem_unstable } from './useMenuItem'; | |||
| import { MenuListProvider } from '../../contexts/menuListContext'; | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 1212 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 486 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium.png | 485 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 1097 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 599 | Changed |
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 605 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 621 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 140 | Changed |
vr-tests-react-components/ProgressBar converged 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png | 95 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png | 67 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png | 68 | Changed |
vr-tests-react-components/Skeleton converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Skeleton converged.Opaque Skeleton with square - Dark Mode.default.chromium.png | 1 | Changed |
vr-tests-react-components/TagPicker 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - High Contrast.chromium.png | 1319 | Changed |
| vr-tests-react-components/TagPicker.disabled - RTL.chromium.png | 635 | Changed |
| vr-tests-react-components/TagPicker.disabled.chromium.png | 677 | Changed |
There were 4 duplicate changes discarded. Check the build logs for more information.
PaulGMardling
marked this pull request as ready for review
July 13, 2026 14:21
PaulGMardling
force-pushed
the
fix/menuitem-ghost-icon
branch
from
July 13, 2026 14:29
e62f7d8 to
00a0c4a
Compare
PaulGMardling
force-pushed
the
fix/menuitem-ghost-icon
branch
from
July 15, 2026 15:07
00a0c4a to
b6042ba
Compare
mainframev
requested changes
Jul 16, 2026
Remove the redundant Cypress TypeScript path override and mark the regression-test change file as non-release-impacting.
mainframev
changed the title
mainframev
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation Details
This PR adds regression tests only for issue #30418.
The underlying product behavior was already fixed earlier in PR #33704 (commit 1466381, authored by ling1726 on 2025-01-24).
A later refactor in PR #36234 moved the logic into a separate hook, but did not introduce the fix itself.
These tests ensure split-group submenu triggers do not render ghost alignment icon/checkmark placeholders, so this behavior does not regress again.
Related Issue(s)
#30418