feat(react-motion): add state motion component factory#36400
Open
robertpenner wants to merge 11 commits into
Open
feat(react-motion): add state motion component factory#36400robertpenner wants to merge 11 commits into
robertpenner wants to merge 11 commits into
Conversation
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 404 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 16 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 16 | Changed |
vr-tests-react-components/ProgressBar converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png | 42 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png | 27 | Changed |
vr-tests-react-components/Skeleton converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Skeleton converged.Opaque Skeleton with rectangle - Dark Mode.default.chromium.png | 9 | Changed |
vr-tests-react-components/TagPicker 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png | 1319 | Changed |
vr-tests/Callout 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Callout.Bottom left edge.default.chromium.png | 2195 | Changed |
| vr-tests/Callout.Bottom left edge - RTL.default.chromium.png | 2199 | Changed |
| vr-tests/Callout.Beak 25.default.chromium.png | 2198 | Changed |
| vr-tests/Callout.Bottom right edge.default.chromium.png | 1130 | Changed |
| vr-tests/Callout.Left bottom edge.default.chromium.png | 3182 | Changed |
| vr-tests/Callout.Right center.default.chromium.png | 2117 | Changed |
vr-tests/Pivot - Overflow 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Pivot - Overflow.Tabs - RTL.chromium.png | 4471 | Changed |
vr-tests/react-charting-VerticalBarChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-VerticalBarChart.Grouped - Wrap Labels.default.chromium.png | 3105 | Changed |
| vr-tests/react-charting-VerticalBarChart.Basic - Secondary Y Axis.default.chromium.png | 3 | Changed |
There were 1 duplicate changes discarded. Check the build logs for more information.
Separate machine topology from motion skins, reserve symbolic state names, and preserve presentation between consecutive transitions.
Demonstrate topology and skin separation with media-player and layout-neutral card-transfer state graphs.
Allow reusable motion skins to map typed layout context to concrete state presentations.
Swap contextual origin and destination roles after each drop so repeated transfers use the same dropped, lifted, and transferred states.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createStateMotionComponent()for flat, deterministic event-driven motion graphscreateStateMotionController()external store and ReactuseStateMotion()subscription hook@fluentui/react-motionand@fluentui/react-componentsValidation
react-motion:test: 99 tests passing, 12 snapshots passingreact-motion:type-checkreact-motion:build --excludeTaskDependenciesreact-motion:lint --excludeTaskDependenciesreact-motion-stories:lint --excludeTaskDependenciesreact-motion:generate-api --excludeTaskDependenciesKnown workspace issue
The aggregate
react-components:generate-apiand story type-check dependency chain are currently blocked by unrelated stale/broken workspace declarations:OverflowReorderObserveris missing from the built@fluentui/react-overflowdeclaration output, and rebuilding that package hits an existing API Extractor internal error while analyzinguseOverflow_unstable.