Skip to content

docs: rename stringifyDataAttribute to toDataAttributeValue in headless docs #36683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Victor Genaev (mainframev) wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −7
Open

docs: rename stringifyDataAttribute to toDataAttributeValue in headless docs #36683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .agents/skills/headless-component/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,14 +241,14 @@ State attributes are the supported CSS targeting contract.
attribute.
- Removal or rename is breaking. Additions require tests and documentation.

Use `stringifyDataAttribute` from `library/src/utils` for presence and string
Use `toDataAttributeValue` from `library/src/utils` for presence and string
attributes:

```tsx
const state: ComponentNameState = useComponentNameBase_unstable(props, ref);

// Applied after consumer props so base state cannot be misrepresented.
state.root['data-disabled'] = stringifyDataAttribute(state.disabled);
state.root['data-disabled'] = toDataAttributeValue(state.disabled);

return state;
```
Expand Down
10 changes: 5 additions & 5 deletions .../react-v9/contributing/rfcs/react-components/convergence/headless-components.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,12 @@ Example (simplified):
```tsx
const state = useButton(props, ref);

// stringifyDataAttribute: returns undefined (omits the attribute) for falsy presence
// attributes, or the string value ("true"/"false"/enum) for boolean/tri-state attributes.
// toDataAttributeValue: returns '' (attribute present) for true, undefined (attribute
// omitted) for false, and the stringified value for enum/tri-state attributes.
Object.assign(state.root, {
'data-disabled': stringifyDataAttribute(state.disabled),
'data-disabled-focusable': stringifyDataAttribute(state.disabledFocusable),
'data-icon-only': stringifyDataAttribute(state.iconOnly),
'data-disabled': toDataAttributeValue(state.disabled),
'data-disabled-focusable': toDataAttributeValue(state.disabledFocusable),
'data-icon-only': toDataAttributeValue(state.iconOnly),
});

return state;
Expand Down
Loading