fix(react-charts): handle stale legend overflow counts - #36691
Open
Jake Salvesen (jakesalvesen) wants to merge 1 commit into
Open
fix(react-charts): handle stale legend overflow counts#36691Jake Salvesen (jakesalvesen) wants to merge 1 commit into
Jake Salvesen (jakesalvesen) wants to merge 1 commit into
Conversation
Open
2 tasks
Author
|
@microsoft-github-policy-service agree |
Jake Salvesen (jakesalvesen)
marked this pull request as ready for review
September 3, 2026 23:46
Author
|
@microsoft/charting-team this is ready for review. The focused Legends regression and package lint pass locally; the PR includes the required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Legendscould crash while reconciling a dynamic item-count change. When an overflowed list shrank,useOverflowMenu()could briefly return the previousoverflowCount; if that count exceeded the currentitemIds.length,remainingItemsCountbecame negative andOverflowMenudereferenceditems[i].propsfor a missing item.This produced
TypeError: Cannot read properties of undefined (reading 'props')and could unmount the containing chart through its React error boundary.New Behavior
@fluentui/react-charts.Validation
Legends.test.tsx: 13 passed, 4 skipped, 5 snapshots passed.react-charts:lint: 0 errors (438 existing package warnings).react-charts:test: 907 passed, 86 skipped; six unrelatedHeatMapChartdate snapshots fail locally on Windows because expectedMar/01/Mar/02render asFeb/29/Mar/01.Related Issue(s)
items[i]is undefined) #36641