Repository navigation
Complete library typing and enforce mypy strict in CI #722
Description
Activity
HardMax71 commented
on Sep 5, 2026 ContributorAuthorMore actionsI do know that typing improvements may be P2/P3 or even lower priority, and bringing a whole library up to strict checking is difficult to do in one pass. I'm happy to help with the implementation in small batches.
If the scope warrants it, I can split this into linked sub-issues and work through them gradually. My idea is to aim for roughly one PR per week, with each diff under 300 lines where practical, so the review workload stays manageable.
HardMax71 commented
on Oct 3, 2026 ContributorAuthorMore actionsVincent Biret (@baywet) Andrew Omondi (@andrueastman) would you be open to this as a series of small PRs? The first would only declare the public exports in four
__init__.pyfiles and add py.typed to bundle, which takes strict mypy from 298 to 203 errors with no runtime change.Hi,
FYI Andrew has left the company for new adventures probably around 2 years ago now.
I'm not opposed to that set of changes in principle, the more work we can delegate to the linter/compiler, the better. A couple of considerations:
- While I'm happy to review community contributions this is my "3rd side job" (not my primary responsibility since I've changed teams over a year ago. So expect delays in reviews, make the PRs small.
- Please take extra considerations for potential breaking changes, we don't want consumers to end up with source breaking changes all of a sudden, especially since strict type checking is not necessarily part of the python culture as far as I understand.
HardMax71 commented
on Oct 5, 2026 ContributorAuthorMore actionsHi,
FYI Andrew has left the company for new adventures probably around 2 years ago now.
I'm not opposed to that set of changes in principle, the more work we can delegate to the linter/compiler, the better. A couple of considerations:
* While I'm happy to review community contributions this is my "3rd side job" (not my primary responsibility since I've changed teams over a year ago. So expect delays in reviews, make the PRs small. * Please take extra considerations for potential breaking changes, we don't want consumers to end up with source breaking changes all of a sudden, especially since strict type checking is not necessarily part of the python culture as far as I understand.Got it. I plan to add a small PR, about 50-100 lines, every week (hopefully).
- added a commit that references this issue
on Oct 5, 2026 - added a commit that references this issue
on Oct 10, 2026
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsNeeds Triage 🔍
Plan and status
Agreed with Vincent Biret (@baywet) on 2026-10-05: small PRs, one at a time, no source-breaking changes. Each PR only adds or tightens annotations, and public names stay importable as they are today (
__all__lists every name a module exports now, sofrom x import *keeps working). When a package reaches zero errors, its[tool.mypy]getsstrict = true, so CI keeps it there.Baseline:
mypy --strictreports 297 errors on main (37492f7, 1.14.2) with mypy 2.3.1. 95 of them are missing explicit exports in four__init__.pyfiles. The numbers in brackets below are the errors each item covers once the items before it land.kiota_abstractions.serialization,kiota_abstractions.store,kiota_http.middlewareandkiota_http.middleware.options, and addpy.typedtokiota_bundle(297 -> 202, no runtime change) (fix: declare public exports for strict type checkers and ship py.typed in bundle #764)strict = truein their[tool.mypy]:kiota_authentication_azure(3),kiota_bundle(2),kiota_serialization_multipart(1),kiota_serialization_form(1),kiota_serialization_text(2),kiota_serialization_json(4) (fix: pass mypy --strict in the small packages and read "false" as False in text #785)RequestAdapterandParsableFactorytype parameters to the top of their range (objectand theParsablebound), so generated clients passmypy --strictwithout regenerating, andstrict = truefortests/validation(141 errors in the validation client, about 26,500 annotations in msgraph-sdk 1.64.0) (fix(abstractions): default the type params of RequestAdapter and ParsableFactory #787)kiota_abstractions.store(22)kiota_abstractions:request_informationand the small modules (13)kiota_abstractions.serializationproxy factories (7), thenstrict = trueforkiota_abstractionskiota_http.middleware.options(25)kiota_http.middleware: retry handler and pipeline (35)kiota_http.middleware: the other handlers (32)kiota_http.httpx_request_adapter(20) and the rest ofkiota_http(4), thenstrict = trueforkiota_httpmypy --stricton a small consumer file using the public APIPR links are added here as each one opens.
Original request
Hi! I use LLMs to help write code, and passing strict type checks such as
mypy --strictis one of my guardrails. A project I'm working on depends on this library, so more complete type information would save me a lot of troubleshooting and help catch mistakes earlier.Is your feature request related to a problem? Please describe.
The library already has substantial type annotations and runs mypy in CI. However, strict checking still exposes gaps that affect consumers. On the checkout described below, ordinary mypy passes, while
mypy --strictreports 298 errors across the eight library packages.For example, checking this consumer code with
mypy --strict example.pyreports implicit-export errors for both imports, an untyped call toget_key(), and anAnyreturn:I also built the
microsoft-kiota-bundlewheel locally and confirmed that it lackspy.typed. Mypy treats an installed import ofkiota_bundle.default_request_adapteras untyped, despite the annotations in its source.Describe the solution you'd like
Complete the existing typing support and enforce strict mypy checks for the library packages.
Suggested definition of done:
mypy --strictin CI with a pinned mypy version across the supported Python versions.py.typed.Anyor disabling checks.I suggest keeping unit-test typing and adopting another checker outside the initial scope. Recurring generated-code annotation changes could be tracked separately with the generator work they require.
Describe alternatives you've considered
Local stubs or per-project mypy overrides could work around individual problems, but would leave consumers maintaining those workarounds. Completing the shared library annotations would benefit dependent projects directly.
Additional context
eef36d7e72197063f234b24407edad15ad873bea; local packages report version 1.12.1.Would you be open to using strict mypy compliance as a tracked enhancement for the library packages?