Repository navigation
CHORE: Bump Linux test cryptography to 50.0.2 - #774
Conversation
Bumps [cryptography](https://github.com/pyca/cryptography) from 48.0.1 to 50.0.0. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@48.0.1...50.0.0) --- updated-dependencies: - dependency-name: cryptography dependency-version: 50.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🟡 Changes recommended
The macOS lockfile changes break existing lockfile validity/contracts (duplicate hashes and missing required pip pin) and the updated macOS cryptography constraint conflicts with enforced compatibility tests.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the engineering (release build/test) dependency lockfiles under eng/, primarily targeting a cryptography upgrade and reflecting a recompiled set of pinned/hashes for the Linux test and macOS build environments.
Changes:
- Update
cryptographypin in the macOS build lock to50.0.0and relax the macOS input constraint from<49to<51. - Update
cryptographypin in the Linux test lock to50.0.0and refresh several locked entries/extras (e.g.,coverage[toml],pyjwt[crypto]) and provenance comments. - Regenerate hashed lock content for macOS build dependencies (but currently with validity issues noted in review comments).
File summaries
| File | Description |
|---|---|
| eng/requirements-test-linux.txt | Updates the Linux test lock, including cryptography==50.0.0 and other lock refresh adjustments. |
| eng/requirements-build-macos.txt | Updates the macOS build lock to cryptography==50.0.0, but currently introduces duplicated hashes and drops the pip pin. |
| eng/requirements-build-macos.in | Relaxes the macOS cryptography constraint to <51, conflicting with existing compatibility contracts/tests. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Merge origin/main, retain the macOS cryptography<49 cap and 48.0.1 lock, and update only Linux test cryptography from 50.0.1 to 50.0.2 with uv 0.12.6. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
PR Performance Report✅ No regression detectedNo consistent slowdowns detected across all 2 environments. 0 IMPROVEMENTS 0 SLOWDOWNS 2/2 ENVIRONMENTS Coverage: 2 of 2 environments completed. Advisory result; does not block merging. Performance diagnosticsPhase times are inclusive diagnostics and must not be added together. They identify where measured time changed, not why it changed. No affected phases or call-count changes were recorded. All database tasks and timingsUnix / SQL Server 2022
Unix / SQL Server 2025
Build and measurement detailsPR head:
A consistent change requires more than 20% median paired movement, at least 1 ms between the median runtimes, and at least 80% of pairs exceeding the relative threshold in the same direction. A slowdown without enough pair agreement is reported as inconsistent. The displayed change is the median of paired before-and-after ratios. It is not recalculated from the two displayed median runtimes. Both revisions use profiling-enabled builds on the same agent and database, with alternating order and discarded warmups. Results are diagnostic and do not represent production-wheel latency. Raw samples and logs are attached to the ADO run as |
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.performance_counter.hpp: 0.7%
mssql_python.pybind.logger_bridge.cpp: 57.9%
mssql_python.pybind.ddbc_bindings.h: 64.5%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python._native_fetch.py: 77.7%
mssql_python.__init__.py: 80.8%
mssql_python.pybind.ddbc_bindings.cpp: 81.4%
mssql_python.pybind.row_mapping_cache.hpp: 81.5%
mssql_python.pybind.connection.connection_pool.cpp: 82.5%
mssql_python.pybind.connection.connection.cpp: 83.1%🔗 Quick Links
|
Preserve the Linux-test-only cryptography 50.0.2 update and macOS cryptography<49 compatibility. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The review identifies only the intended Linux cryptography pin and hash refresh, while preserving platform-specific constraints and unrelated dependencies with no outstanding issues noted.
No open issues 🎉
Review effort: Lite
|
/azp run MSSQL-Python-PR-Validation |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Jahnvi Thakkar (jahnvi480)
left a comment
There was a problem hiding this comment.
The Linux test cryptography lock update preserves the reviewed dependency closure and macOS compatibility constraint. Azure build 191865 passed all 23 jobs, and both exact-head paired Linux SQL Server performance reports validated with no regressions flagged under the existing policy. This is measured profiling-enabled coverage, not a guarantee of zero production latency change.
Keep the Linux test cryptography 50.0.2 version/hash-only delta and macOS compatibility cap unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
/azp run MSSQL-Python-PR-Validation |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
🔵 Needs a closer look
The generated hash lock cannot be verified here because confirming all cryptography 50.0.2 artifact hashes and universal markers requires unavailable network-backed uv/PyPI or pip validation.
No open issues 🎉
Review effort: Lite
|
/azp run MSSQL-Python-PR-Validation |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Preserve the Linux cryptography 50.0.2 version/hash-only update and the macOS compatibility cap. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
/azp run MSSQL-Python-PR-Validation |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Retain the Linux test cryptography 50.0.2-only delta, macOS cryptography<49 cap, and all upstream dependency pins and markers. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
/azp run MSSQL-Python-PR-Validation |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |


Work Item / Issue Reference
Summary
Upgrade cryptography from 50.0.1 to 50.0.2 in the Linux test dependency lock with generated artifact hashes. Preserve the macOS cryptography<49 constraint and compatible 48.0.1 lock for x86_64 wheels. Resolve conflicts against main while retaining all unrelated dependency versions, complete hash-locked closures, and supported Python/platform markers. The net change is limited to the Linux test lock.