Skip to content

CHORE: Bump Linux test cryptography to 50.0.2 - #774

Merged
Jahnvi Thakkar (jahnvi480) merged 7 commits into
mainfrom
dependabot/pip/eng/cryptography-50.0.0
Nov 17, 2026
Merged

Jahnvi Thakkar (jahnvi480) merged 7 commits into
mainfrom
dependabot/pip/eng/cryptography-50.0.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Work Item / Issue Reference

AB#47861

GitHub Issue: N/A


Summary

Upgrade cryptography from 50.0.1 to 50.0.2 in the Linux test dependency lock with generated artifact hashes. Preserve the macOS cryptography<49 constraint and compatible 48.0.1 lock for x86_64 wheels. Resolve conflicts against main while retaining all unrelated dependency versions, complete hash-locked closures, and supported Python/platform markers. The net change is limited to the Linux test lock.

Bumps [cryptography](https://github.com/pyca/cryptography) from 48.0.1 to 50.0.0.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@48.0.1...50.0.0)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-version: 50.0.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Copilot AI lite review requested due to automatic review settings September 10, 2026 12:40
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file python Pull requests that update python code labels Sep 10, 2026
@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The macOS lockfile changes break existing lockfile validity/contracts (duplicate hashes and missing required pip pin) and the updated macOS cryptography constraint conflicts with enforced compatibility tests.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the engineering (release build/test) dependency lockfiles under eng/, primarily targeting a cryptography upgrade and reflecting a recompiled set of pinned/hashes for the Linux test and macOS build environments.

Changes:

  • Update cryptography pin in the macOS build lock to 50.0.0 and relax the macOS input constraint from <49 to <51.
  • Update cryptography pin in the Linux test lock to 50.0.0 and refresh several locked entries/extras (e.g., coverage[toml], pyjwt[crypto]) and provenance comments.
  • Regenerate hashed lock content for macOS build dependencies (but currently with validity issues noted in review comments).
File summaries
File Description
eng/requirements-test-linux.txt Updates the Linux test lock, including cryptography==50.0.0 and other lock refresh adjustments.
eng/requirements-build-macos.txt Updates the macOS build lock to cryptography==50.0.0, but currently introduces duplicated hashes and drops the pip pin.
eng/requirements-build-macos.in Relaxes the macOS cryptography constraint to <51, conflicting with existing compatibility contracts/tests.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread eng/requirements-build-macos.in Resolved
Comment thread eng/requirements-test-linux.txt Resolved
@jahnvi480 Jahnvi Thakkar (jahnvi480) changed the title Build(deps): Bump cryptography from 48.0.1 to 50.0.0 in /eng CHORE: Preserve platform compatibility in cryptography dependency updates Nov 12, 2026
Merge origin/main, retain the macOS cryptography<49 cap and 48.0.1 lock, and update only Linux test cryptography from 50.0.1 to 50.0.2 with uv 0.12.6.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings November 12, 2026 11:27
@github-actions github-actions Bot added the pr-size: medium Moderate update size label Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

PR Performance Report

✅ No regression detected

No consistent slowdowns detected across all 2 environments.

0 IMPROVEMENTS 0 SLOWDOWNS 2/2 ENVIRONMENTS

Coverage: 2 of 2 environments completed. Advisory result; does not block merging.

Performance diagnostics

Phase times are inclusive diagnostics and must not be added together. They identify where measured time changed, not why it changed.

No affected phases or call-count changes were recorded.

All database tasks and timings

Unix / SQL Server 2022

Database task Before After Paired change Result
Connection opening 11.801 ms 11.982 ms +2.2% no signal
SELECT queries 1.228 ms 1.038 ms -15.3% no signal
Row insertion 29.456 ms 29.617 ms +0.1% no signal
Executemany inserts 144.839 ms 146.828 ms -1.4% no signal
Fetch-all queries 123.152 ms 125.801 ms +2.0% no signal
Row-by-row fetching 4.751 ms 4.819 ms +3.8% no signal
Batched row fetching 115.436 ms 111.989 ms -2.5% no signal
Transaction commit and rollback 100.616 ms 100.056 ms -0.5% no signal
Arrow row fetching 90.497 ms 87.362 ms -3.1% no signal
100,000-row insertion 351.245 ms 346.785 ms +3.4% no signal
Row fetching in batches of 100 109.526 ms 108.779 ms -0.8% no signal
Row fetching in batches of 10,000 148.144 ms 131.310 ms -11.1% no signal
Repeated positional queries 31.358 ms 30.299 ms -3.0% no signal
Repeated named-parameter queries 30.696 ms 30.770 ms +0.4% no signal
Legacy 100,000-row insertion 244.119 ms 248.585 ms +2.7% no signal
Insertion with explicit input sizes 381.463 ms 383.182 ms +3.5% no signal
Joined aggregation queries 193.983 ms 190.799 ms -2.0% no signal
Large joined-result fetching 211.137 ms 205.551 ms -0.9% no signal
1.2-million-row fetching 3561.143 ms 3567.726 ms +0.3% no signal
Common table expression queries 5.699 ms 5.869 ms +2.0% no signal
256 KiB VARCHAR(MAX) / fetchall() 1.366 ms 1.392 ms +3.2% no signal
10,000 scalar values / fetchval() (debug disabled) 16.692 ms 16.904 ms +2.6% no signal
10,000 output-converted rows / fetchall() 19.693 ms 19.867 ms +0.6% no signal
10,000 output-converted rows / fetchmany(1000) 24.796 ms 25.595 ms +5.0% no signal
10,000 INT/NVARCHAR rows / fetchmany(1) 24.590 ms 24.783 ms +0.8% no signal
10,000 rows x 32 columns / dict(row._mapping) (warm) 34.090 ms 33.717 ms -4.6% no signal

Unix / SQL Server 2025

Database task Before After Paired change Result
Connection opening 80.711 ms 81.129 ms +0.5% no signal
SELECT queries 1.125 ms 0.978 ms -12.3% no signal
Row insertion 30.315 ms 30.343 ms +0.5% no signal
Executemany inserts 155.215 ms 155.441 ms +0.6% no signal
Fetch-all queries 120.101 ms 119.636 ms -0.6% no signal
Row-by-row fetching 5.023 ms 5.075 ms +0.5% no signal
Batched row fetching 117.047 ms 117.015 ms +0.6% no signal
Transaction commit and rollback 105.553 ms 105.335 ms -0.3% no signal
Arrow row fetching 94.858 ms 89.879 ms -5.8% no signal
100,000-row insertion 356.974 ms 356.868 ms -0.3% no signal
Row fetching in batches of 100 122.097 ms 120.896 ms -0.7% no signal
Row fetching in batches of 10,000 126.841 ms 133.333 ms +3.4% no signal
Repeated positional queries 31.434 ms 31.480 ms +0.3% no signal
Repeated named-parameter queries 31.554 ms 31.545 ms -1.1% no signal
Legacy 100,000-row insertion 253.693 ms 254.738 ms +0.2% no signal
Insertion with explicit input sizes 398.109 ms 396.075 ms -1.0% no signal
Joined aggregation queries 165.414 ms 165.049 ms +1.8% no signal
Large joined-result fetching 183.661 ms 184.901 ms +0.3% no signal
1.2-million-row fetching 3500.204 ms 3496.421 ms -0.1% no signal
Common table expression queries 5.089 ms 5.365 ms +8.6% no signal
256 KiB VARCHAR(MAX) / fetchall() 1.946 ms 1.998 ms +2.7% no signal
10,000 scalar values / fetchval() (debug disabled) 16.898 ms 16.974 ms +0.7% no signal
10,000 output-converted rows / fetchall() 19.802 ms 31.168 ms +6.0% no signal
10,000 output-converted rows / fetchmany(1000) 23.061 ms 24.215 ms +4.5% no signal
10,000 INT/NVARCHAR rows / fetchmany(1) 24.704 ms 24.828 ms +1.3% no signal
10,000 rows x 32 columns / dict(row._mapping) (warm) 31.241 ms 31.593 ms +0.4% no signal
Build and measurement details

ADO build 192976

PR head: e69d663405f9f7e22af8f4d5d7ae0407079344f9
Base: 6674647100b2c62f2c7da7a3c3c53c3dfc494143
Measured merge: 1157c3c5720488e7a49b27c1c2198423ea97e366

  • Unix / SQL Server 2022: Python 3.12.3, x86_64, SQL 16.0.4325.4; 5 paired comparisons and 1 warmup.
  • Unix / SQL Server 2025: Python 3.12.3, x86_64, SQL 17.0.5065.9; 5 paired comparisons and 1 warmup.

A consistent change requires more than 20% median paired movement, at least 1 ms between the median runtimes, and at least 80% of pairs exceeding the relative threshold in the same direction. A slowdown without enough pair agreement is reported as inconsistent.

The displayed change is the median of paired before-and-after ratios. It is not recalculated from the two displayed median runtimes.

Both revisions use profiling-enabled builds on the same agent and database, with alternating order and discarded warmups. Results are diagnostic and do not represent production-wheel latency.

Raw samples and logs are attached to the ADO run as profiler-* artifacts.

@jahnvi480 Jahnvi Thakkar (jahnvi480) changed the title CHORE: Preserve platform compatibility in cryptography dependency updates CHORE: Bump Linux test cryptography to 50.0.2 Nov 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the dependency lock update, which preserves the existing platform-specific compatibility constraint.

No open issues 🎉

2 resolved since last review

Review effort: Lite

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

📊 Code Coverage Report

🔥 Diff Coverage

100%


🎯 Overall Coverage

86%


📈 Total Lines Covered: 11690 out of 13576
📁 Project: mssql-python


Diff Coverage

Diff: main...HEAD, staged and unstaged changes

No lines with coverage information in this diff.


📋 Files Needing Attention

📉 Files with overall lowest coverage (click to expand)
mssql_python.pybind.performance_counter.hpp: 0.7%
mssql_python.pybind.logger_bridge.cpp: 57.9%
mssql_python.pybind.ddbc_bindings.h: 64.5%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python._native_fetch.py: 77.7%
mssql_python.__init__.py: 80.8%
mssql_python.pybind.ddbc_bindings.cpp: 81.4%
mssql_python.pybind.row_mapping_cache.hpp: 81.5%
mssql_python.pybind.connection.connection_pool.cpp: 82.5%
mssql_python.pybind.connection.connection.cpp: 83.1%

🔗 Quick Links

⚙️ Build Summary 📋 Coverage Details

View Azure DevOps Build

Browse Full Coverage Report

Preserve the Linux-test-only cryptography 50.0.2 update and macOS cryptography<49 compatibility.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings November 13, 2026 09:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review identifies only the intended Linux cryptography pin and hash refresh, while preserving platform-specific constraints and unrelated dependencies with no outstanding issues noted.

No open issues 🎉

Review effort: Lite

@jahnvi480

Copy link
Copy Markdown
Contributor

/azp run MSSQL-Python-PR-Validation

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Linux test cryptography lock update preserves the reviewed dependency closure and macOS compatibility constraint. Azure build 191865 passed all 23 jobs, and both exact-head paired Linux SQL Server performance reports validated with no regressions flagged under the existing policy. This is measured profiling-enabled coverage, not a guarantee of zero production latency change.

Keep the Linux test cryptography 50.0.2 version/hash-only delta and macOS compatibility cap unchanged.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings November 13, 2026 17:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The Linux test dependency lock updates cryptography and its artifact hashes while preserving the existing macOS configuration, with no active review issues identified.

No open issues 🎉

Review effort: Lite

@jahnvi480

Copy link
Copy Markdown
Contributor

/azp run MSSQL-Python-PR-Validation

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 1 pipeline(s).

Copilot AI lite review requested due to automatic review settings November 16, 2026 04:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The generated hash lock cannot be verified here because confirming all cryptography 50.0.2 artifact hashes and universal markers requires unavailable network-backed uv/PyPI or pip validation.

No open issues 🎉

Review effort: Lite

@jahnvi480

Copy link
Copy Markdown
Contributor

/azp run MSSQL-Python-PR-Validation

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 1 pipeline(s).

Preserve the Linux cryptography 50.0.2 version/hash-only update and the macOS compatibility cap.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings November 16, 2026 05:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is limited to updating the Linux cryptography pin and hashes while preserving the existing lock structure and macOS constraint, with no active review issues identified.

No open issues 🎉

Review effort: Lite

@jahnvi480

Copy link
Copy Markdown
Contributor

/azp run MSSQL-Python-PR-Validation

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 1 pipeline(s).

Retain the Linux test cryptography 50.0.2-only delta, macOS cryptography<49 cap, and all upstream dependency pins and markers.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings November 17, 2026 19:58
@jahnvi480

Copy link
Copy Markdown
Contributor

/azp run MSSQL-Python-PR-Validation

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 1 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, and the Linux test lock update is limited in scope with refreshed cryptography 50.0.2 artifact hashes.

No open issues 🎉

Review effort: Lite

@jahnvi480
Jahnvi Thakkar (jahnvi480) merged commit 5a4570a into main Nov 17, 2026
74 of 76 checks passed
@dependabot
dependabot Bot deleted the dependabot/pip/eng/cryptography-50.0.0 branch November 17, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file pr-size: medium Moderate update size python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants