Skip to content

CHORE: Bump urllib3 to 2.8.0 in release and publisher locks - #830

Merged
Jahnvi Thakkar (jahnvi480) merged 7 commits into
mainfrom
dependabot/pip/eng/urllib3-2.8.0
Nov 18, 2026
Merged

Jahnvi Thakkar (jahnvi480) merged 7 commits into
mainfrom
dependabot/pip/eng/urllib3-2.8.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Work Item / Issue Reference

AB#47861

GitHub Issue: N/A


Summary

Upgrade urllib3 from 2.7.0 to 2.8.0 in release dependency locks and the Windows CPython 3.13 Conda publisher lock. Resolve conflicts against current main and regenerate complete, hash-locked dependency closures while preserving universal Python/platform markers, the Windows-specific ODBC target, and unrelated reviewed dependency versions. The publisher update also addresses the reviewed urllib3 advisory version ranges affecting 2.7.0.

Validation: workflow-equivalent regeneration of all three release locks passed; all 37 release-lock target resolution checks passed using cached metadata. The publisher lock reproduced byte-for-byte from the target wheel set; a fresh Windows CPython 3.13 binary-only, hash-enforced installation of all 66 packages, pip check, and publisher import/version smoke checks passed. The pinned full Black pre-push check and actual push hook passed. Fresh exact-head Azure CI and paired performance results remain pending; no regression-clearance claim is made from earlier artifacts.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file python Pull requests that update python code labels Oct 1, 2026
Copilot AI balanced review requested due to automatic review settings October 1, 2026 18:47
@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

PR Performance Report

✅ No regression detected

No consistent slowdowns detected across all 2 environments.

0 IMPROVEMENTS 0 SLOWDOWNS 2/2 ENVIRONMENTS

Coverage: 2 of 2 environments completed. Advisory result; does not block merging.

Performance diagnostics

Phase times are inclusive diagnostics and must not be added together. They identify where measured time changed, not why it changed.

No affected phases or call-count changes were recorded.

All database tasks and timings

Unix / SQL Server 2022

Database task Before After Paired change Result
Connection opening 10.827 ms 11.444 ms +5.4% no signal
SELECT queries 0.999 ms 0.993 ms -0.6% no signal
Row insertion 28.828 ms 29.155 ms +1.2% no signal
Executemany inserts 136.804 ms 142.098 ms +3.2% no signal
Fetch-all queries 116.804 ms 118.281 ms +1.3% no signal
Row-by-row fetching 4.774 ms 4.824 ms +0.9% no signal
Batched row fetching 110.289 ms 110.316 ms -0.2% no signal
Transaction commit and rollback 97.430 ms 97.189 ms -0.2% no signal
Arrow row fetching 87.514 ms 85.527 ms -0.8% no signal
100,000-row insertion 340.335 ms 321.798 ms -5.4% no signal
Row fetching in batches of 100 106.834 ms 108.307 ms +1.0% no signal
Row fetching in batches of 10,000 118.813 ms 134.215 ms +6.1% no signal
Repeated positional queries 29.648 ms 29.520 ms -0.7% no signal
Repeated named-parameter queries 30.026 ms 29.952 ms -0.4% no signal
Legacy 100,000-row insertion 227.949 ms 226.413 ms -0.3% no signal
Insertion with explicit input sizes 359.581 ms 344.042 ms -0.2% no signal
Joined aggregation queries 190.197 ms 189.737 ms -1.2% no signal
Large joined-result fetching 187.779 ms 189.425 ms +0.9% no signal
1.2-million-row fetching 3504.249 ms 3508.747 ms +0.4% no signal
Common table expression queries 5.610 ms 5.565 ms -2.0% no signal
256 KiB VARCHAR(MAX) / fetchall() 1.286 ms 1.284 ms -0.2% no signal
10,000 scalar values / fetchval() (debug disabled) 16.615 ms 16.594 ms +0.6% no signal
10,000 output-converted rows / fetchall() 19.192 ms 19.163 ms -0.3% no signal
10,000 output-converted rows / fetchmany(1000) 23.311 ms 23.504 ms +1.0% no signal
10,000 INT/NVARCHAR rows / fetchmany(1) 24.435 ms 24.694 ms +0.3% no signal
10,000 rows x 32 columns / dict(row._mapping) (warm) 32.693 ms 32.853 ms +2.4% no signal

Unix / SQL Server 2025

Database task Before After Paired change Result
Connection opening 81.634 ms 81.295 ms -0.4% no signal
SELECT queries 0.998 ms 0.993 ms -1.1% no signal
Row insertion 30.369 ms 30.263 ms -0.2% no signal
Executemany inserts 155.681 ms 157.415 ms +0.3% no signal
Fetch-all queries 122.870 ms 121.082 ms -2.2% no signal
Row-by-row fetching 5.009 ms 5.087 ms +2.0% no signal
Batched row fetching 116.946 ms 119.035 ms +1.3% no signal
Transaction commit and rollback 114.028 ms 106.267 ms -7.4% no signal
Arrow row fetching 88.425 ms 90.498 ms +2.3% no signal
100,000-row insertion 390.961 ms 346.132 ms -6.0% no signal
Row fetching in batches of 100 120.597 ms 122.264 ms +0.2% no signal
Row fetching in batches of 10,000 136.525 ms 135.162 ms -2.3% no signal
Repeated positional queries 35.783 ms 31.378 ms -12.6% no signal
Repeated named-parameter queries 33.177 ms 32.255 ms -1.9% no signal
Legacy 100,000-row insertion 271.184 ms 257.692 ms +0.4% no signal
Insertion with explicit input sizes 383.246 ms 396.033 ms +1.1% no signal
Joined aggregation queries 165.344 ms 165.320 ms +0.2% no signal
Large joined-result fetching 194.020 ms 186.512 ms -4.4% no signal
1.2-million-row fetching 3513.220 ms 3512.225 ms -0.6% no signal
Common table expression queries 5.165 ms 5.154 ms +0.6% no signal
256 KiB VARCHAR(MAX) / fetchall() 1.981 ms 2.033 ms -5.5% no signal
10,000 scalar values / fetchval() (debug disabled) 17.350 ms 17.033 ms -1.3% no signal
10,000 output-converted rows / fetchall() 19.690 ms 19.869 ms +0.9% no signal
10,000 output-converted rows / fetchmany(1000) 23.631 ms 23.991 ms +1.5% no signal
10,000 INT/NVARCHAR rows / fetchmany(1) 24.546 ms 25.047 ms +1.1% no signal
10,000 rows x 32 columns / dict(row._mapping) (warm) 31.855 ms 31.661 ms -0.0% no signal
Build and measurement details

ADO build 193036

PR head: 99f77b1b81df9867c85eb45a8de4ed4bf284ee93
Base: 5a4570a76e7dc9398de65358f0c0c1eabf8bc900
Measured merge: 86f9401a9ea907518dafb24491cc99f34757317d

  • Unix / SQL Server 2022: Python 3.12.3, x86_64, SQL 16.0.4325.4; 5 paired comparisons and 1 warmup.
  • Unix / SQL Server 2025: Python 3.12.3, x86_64, SQL 17.0.5065.9; 5 paired comparisons and 1 warmup.

A consistent change requires more than 20% median paired movement, at least 1 ms between the median runtimes, and at least 80% of pairs exceeding the relative threshold in the same direction. A slowdown without enough pair agreement is reported as inconsistent.

The displayed change is the median of paired before-and-after ratios. It is not recalculated from the two displayed median runtimes.

Both revisions use profiling-enabled builds on the same agent and database, with alternating order and discarded warmups. Results are diagnostic and do not represent production-wheel latency.

Raw samples and logs are attached to the ADO run as profiler-* artifacts.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The locks were generated for incorrect Python/platform targets and can fail hash-required CI installations.

Review effort: Balanced
Findings: None

What changed in this PR

Updates urllib3 from 2.7.0 to 2.8.0 in engineering dependency locks.

Changes:

  • Updates urllib3 and hashes.
  • Regenerates Linux, macOS, and ODBC dependency closures.
File Description
eng/​requirements-test-linux.txt Updates the Linux test lock.
eng/​requirements-build-odbc.txt Updates the ODBC build lock.
eng/​requirements-build-macos.txt Updates the macOS build lock.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI balanced review requested due to automatic review settings October 12, 2026 06:25
@dependabot
dependabot Bot force-pushed the dependabot/pip/eng/urllib3-2.8.0 branch from b9250b8 to d6987ea Compare October 12, 2026 06:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The regenerated locks omit required Python 3.10 dependencies, contain Linux dependencies in a Windows lock, and leave the Conda publisher on urllib3 2.7.0.

1 open finding

🧠 Review effort: Balanced

Comment thread eng/requirements-test-linux.txt Resolved
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.7.0 to 2.8.0.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.7.0...2.8.0)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-version: 2.8.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Copilot AI balanced review requested due to automatic review settings October 12, 2026 08:50
@dependabot
dependabot Bot force-pushed the dependabot/pip/eng/urllib3-2.8.0 branch from d6987ea to f86101d Compare October 12, 2026 08:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The regenerated locks omit Python 3.15 pyarrow and contain Linux dependencies in the Windows ODBC lock.

1 open finding

🧠 Review effort: Balanced

@jahnvi480 Jahnvi Thakkar (jahnvi480) changed the title Build(deps): Bump urllib3 from 2.7.0 to 2.8.0 in /eng CHORE: Bump urllib3 to 2.8.0 in release dependency locks Nov 12, 2026
Preserve reviewed dependency closures and universal Python markers while updating urllib3 to 2.8.0. Restore Windows-specific ODBC dependencies using the pinned refresh workflow.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 12, 2026 11:26
@github-actions github-actions Bot added the pr-size: small Minimal code update label Nov 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The urllib3 2.8.0 artifact hashes and supported Python/platform compatibility cannot be verified offline, so passing lock-regeneration and release-matrix validation jobs must be confirmed before merging.

1 open issue

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

📊 Code Coverage Report

🔥 Diff Coverage

100%


🎯 Overall Coverage

86%


📈 Total Lines Covered: 11690 out of 13576
📁 Project: mssql-python


Diff Coverage

Diff: main...HEAD, staged and unstaged changes

No lines with coverage information in this diff.


📋 Files Needing Attention

📉 Files with overall lowest coverage (click to expand)
mssql_python.pybind.performance_counter.hpp: 0.7%
mssql_python.pybind.logger_bridge.cpp: 57.9%
mssql_python.pybind.ddbc_bindings.h: 64.5%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python._native_fetch.py: 77.7%
mssql_python.__init__.py: 80.8%
mssql_python.pybind.ddbc_bindings.cpp: 81.4%
mssql_python.pybind.row_mapping_cache.hpp: 81.5%
mssql_python.pybind.connection.connection_pool.cpp: 82.5%
mssql_python.pybind.connection.connection.cpp: 83.1%

🔗 Quick Links

⚙️ Build Summary 📋 Coverage Details

View Azure DevOps Build

Browse Full Coverage Report

Update the Windows CPython 3.13 Conda publisher to urllib3 2.8.0 for GHSA-gh4c-6fx4-qh6g, GHSA-vxq7-64xx-v4gw, and GHSA-8988-9cw3-xx77. Regenerate its target-wheel hash lock with uv 0.12.6 while preserving every unrelated pin and hash.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 13, 2026 09:40
@jahnvi480

Copy link
Copy Markdown
Contributor

/azp run MSSQL-Python-PR-Validation

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 1 pipeline(s).

@jahnvi480 Jahnvi Thakkar (jahnvi480) changed the title CHORE: Bump urllib3 to 2.8.0 in release dependency locks CHORE: Bump urllib3 to 2.8.0 in release and publisher locks Nov 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the urllib3 dependency-lock updates.

1 open issue

Review effort: Balanced

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reviewed urllib3-only lock update preserves the validated dependency closures and target hashes, including the Conda publisher update. Azure build 191870 passed all 23 jobs; the macOS SQL Server 2025 job passed its bounded retry after the original hosted-agent loss. Both exact-head paired Linux SQL Server performance reports validated without a consistent regression under the existing policy; profiling-enabled evidence is not a guarantee of zero effect or universal release latency.

Preserve the four reviewed urllib3 2.8.0 lock updates while incorporating current main without rewriting history.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 13, 2026 17:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The urllib3 dependency-lock update has no active review issues.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@jahnvi480

Copy link
Copy Markdown
Contributor

/azp run MSSQL-Python-PR-Validation

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 1 pipeline(s).

Copilot AI balanced review requested due to automatic review settings November 16, 2026 04:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the urllib3 dependency-lock update.

No open issues 🎉

Review effort: Balanced

@jahnvi480

Copy link
Copy Markdown
Contributor

/azp run MSSQL-Python-PR-Validation

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 1 pipeline(s).

Preserve the complete build and publisher urllib3 2.8.0 locks while incorporating the reviewed main dependency changes without rewriting history.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 05:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the urllib3 dependency-lock update.

No open issues 🎉

Review effort: Balanced

@jahnvi480

Copy link
Copy Markdown
Contributor

/azp run MSSQL-Python-PR-Validation

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 1 pipeline(s).

Retain the four urllib3 2.8.0 lock updates and complete publisher closure while preserving all newly merged dependency pins, hashes, and markers.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 22:35
@jahnvi480

Copy link
Copy Markdown
Contributor

/azp run MSSQL-Python-PR-Validation

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 1 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the urllib3 dependency-lock update.

No open issues 🎉

Review effort: Balanced

@jahnvi480
Jahnvi Thakkar (jahnvi480) merged commit b23b04b into main Nov 18, 2026
54 checks passed
@dependabot
dependabot Bot deleted the dependabot/pip/eng/urllib3-2.8.0 branch November 18, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file pr-size: small Minimal code update python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants