Repository navigation
CHORE: Bump urllib3 to 2.8.0 in release and publisher locks - #830
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
PR Performance Report✅ No regression detectedNo consistent slowdowns detected across all 2 environments. 0 IMPROVEMENTS 0 SLOWDOWNS 2/2 ENVIRONMENTS Coverage: 2 of 2 environments completed. Advisory result; does not block merging. Performance diagnosticsPhase times are inclusive diagnostics and must not be added together. They identify where measured time changed, not why it changed. No affected phases or call-count changes were recorded. All database tasks and timingsUnix / SQL Server 2022
Unix / SQL Server 2025
Build and measurement detailsPR head:
A consistent change requires more than 20% median paired movement, at least 1 ms between the median runtimes, and at least 80% of pairs exceeding the relative threshold in the same direction. A slowdown without enough pair agreement is reported as inconsistent. The displayed change is the median of paired before-and-after ratios. It is not recalculated from the two displayed median runtimes. Both revisions use profiling-enabled builds on the same agent and database, with alternating order and discarded warmups. Results are diagnostic and do not represent production-wheel latency. Raw samples and logs are attached to the ADO run as |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The locks were generated for incorrect Python/platform targets and can fail hash-required CI installations.
Review effort: Balanced
Findings: None
What changed in this PR
Updates urllib3 from 2.7.0 to 2.8.0 in engineering dependency locks.
Changes:
- Updates urllib3 and hashes.
- Regenerates Linux, macOS, and ODBC dependency closures.
| File | Description |
|---|---|
eng/requirements-test-linux.txt |
Updates the Linux test lock. |
eng/requirements-build-odbc.txt |
Updates the ODBC build lock. |
eng/requirements-build-macos.txt |
Updates the macOS build lock. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
b9250b8 to
d6987ea
Compare
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.7.0 to 2.8.0. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.7.0...2.8.0) --- updated-dependencies: - dependency-name: urllib3 dependency-version: 2.8.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
d6987ea to
f86101d
Compare
Preserve reviewed dependency closures and universal Python markers while updating urllib3 to 2.8.0. Restore Windows-specific ODBC dependencies using the pinned refresh workflow. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The urllib3 2.8.0 artifact hashes and supported Python/platform compatibility cannot be verified offline, so passing lock-regeneration and release-matrix validation jobs must be confirmed before merging.
1 open issue
Review effort: Balanced
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.performance_counter.hpp: 0.7%
mssql_python.pybind.logger_bridge.cpp: 57.9%
mssql_python.pybind.ddbc_bindings.h: 64.5%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python._native_fetch.py: 77.7%
mssql_python.__init__.py: 80.8%
mssql_python.pybind.ddbc_bindings.cpp: 81.4%
mssql_python.pybind.row_mapping_cache.hpp: 81.5%
mssql_python.pybind.connection.connection_pool.cpp: 82.5%
mssql_python.pybind.connection.connection.cpp: 83.1%🔗 Quick Links
|
Update the Windows CPython 3.13 Conda publisher to urllib3 2.8.0 for GHSA-gh4c-6fx4-qh6g, GHSA-vxq7-64xx-v4gw, and GHSA-8988-9cw3-xx77. Regenerate its target-wheel hash lock with uv 0.12.6 while preserving every unrelated pin and hash. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
/azp run MSSQL-Python-PR-Validation |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Jahnvi Thakkar (jahnvi480)
left a comment
There was a problem hiding this comment.
The reviewed urllib3-only lock update preserves the validated dependency closures and target hashes, including the Conda publisher update. Azure build 191870 passed all 23 jobs; the macOS SQL Server 2025 job passed its bounded retry after the original hosted-agent loss. Both exact-head paired Linux SQL Server performance reports validated without a consistent regression under the existing policy; profiling-enabled evidence is not a guarantee of zero effect or universal release latency.
Preserve the four reviewed urllib3 2.8.0 lock updates while incorporating current main without rewriting history. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
/azp run MSSQL-Python-PR-Validation |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
/azp run MSSQL-Python-PR-Validation |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Preserve the complete build and publisher urllib3 2.8.0 locks while incorporating the reviewed main dependency changes without rewriting history. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
/azp run MSSQL-Python-PR-Validation |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Retain the four urllib3 2.8.0 lock updates and complete publisher closure while preserving all newly merged dependency pins, hashes, and markers. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
/azp run MSSQL-Python-PR-Validation |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |

Work Item / Issue Reference
Summary
Upgrade urllib3 from 2.7.0 to 2.8.0 in release dependency locks and the Windows CPython 3.13 Conda publisher lock. Resolve conflicts against current main and regenerate complete, hash-locked dependency closures while preserving universal Python/platform markers, the Windows-specific ODBC target, and unrelated reviewed dependency versions. The publisher update also addresses the reviewed urllib3 advisory version ranges affecting 2.7.0.
Validation: workflow-equivalent regeneration of all three release locks passed; all 37 release-lock target resolution checks passed using cached metadata. The publisher lock reproduced byte-for-byte from the target wheel set; a fresh Windows CPython 3.13 binary-only, hash-enforced installation of all 66 packages, pip check, and publisher import/version smoke checks passed. The pinned full Black pre-push check and actual push hook passed. Fresh exact-head Azure CI and paired performance results remain pending; no regression-clearance claim is made from earlier artifacts.