Skip to content

FIX: Restore release package pipeline - #900

Merged
Jahnvi Thakkar (jahnvi480) merged 7 commits into
mainfrom
bewithgaurav/fix-linux-build-image-pulls
Nov 18, 2026
Merged

Jahnvi Thakkar (jahnvi480) merged 7 commits into
mainfrom
bewithgaurav/fix-linux-build-image-pulls

Conversation

@bewithgaurav

@bewithgaurav Gaurav Sharma (bewithgaurav) commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Work Item / Issue Reference

AB#50320


Summary

Restore the release package pipeline after four independent blockers.

  • Pull the original public PyPA manylinux and musllinux images directly from Quay because hosted 1ES agents cannot reach GHCR reliably.
  • Retry container startup up to five times for transient registry failures.
  • Allow four hours for six serial Linux build/test cycles under QEMU-based ARM64 emulation.
  • Default the NonOfficial Rust test override to the queue-safe committed sentinel required by the ADO manual-run form.
  • Map committed to an empty override so Official builds use the pinned public release from eng/versions/mssql-python-rs.version.
  • Remove a synthetic native-fetch test that mutates private policy state production cannot create.

The native-fetch test passed PR validation on Python 3.13.17 but failed the release pool on Python 3.13.11 because the pipelines float different patch versions. No production native-fetch behavior changes.

Validation

  • Merged current GitHub main into this branch before applying the unblock.
  • An ADO Official preview expanded MSSQL_PYTHON_RS_VERSION to an empty value and effectiveOneBranchType to Official.
  • 46 runtime pipeline tests passed; 16 platform-dependent tests skipped.
  • The Linux stage YAML resolves timeoutInMinutes to 240.
  • All four x86_64 and aarch64 Quay manifests returned HTTP 200.
  • Modified Python and YAML files parsed successfully.
  • git diff --check passed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 11:19
@github-actions github-actions Bot added the pr-size: small Minimal code update label Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

PR Performance Report

✅ No regression detected

No consistent slowdowns detected across all 2 environments.

0 IMPROVEMENTS 0 SLOWDOWNS 2/2 ENVIRONMENTS

Coverage: 2 of 2 environments completed. Advisory result; does not block merging.

Performance diagnostics

Phase times are inclusive diagnostics and must not be added together. They identify where measured time changed, not why it changed.

No affected phases or call-count changes were recorded.

All database tasks and timings

Unix / SQL Server 2022

Database task Before After Paired change Result
Connection opening 10.147 ms 10.297 ms +1.9% no signal
SELECT queries 0.996 ms 1.009 ms +1.2% no signal
Row insertion 31.098 ms 30.829 ms -0.1% no signal
Executemany inserts 162.654 ms 164.996 ms -0.9% no signal
Fetch-all queries 117.539 ms 117.211 ms -0.1% no signal
Row-by-row fetching 4.849 ms 4.834 ms -0.5% no signal
Batched row fetching 116.902 ms 116.039 ms -0.7% no signal
Transaction commit and rollback 106.927 ms 106.728 ms -0.2% no signal
Arrow row fetching 89.518 ms 89.470 ms +0.5% no signal
100,000-row insertion 349.553 ms 343.975 ms -2.6% no signal
Row fetching in batches of 100 119.659 ms 119.740 ms +0.1% no signal
Row fetching in batches of 10,000 135.328 ms 132.834 ms +1.7% no signal
Repeated positional queries 32.116 ms 32.084 ms -0.1% no signal
Repeated named-parameter queries 32.536 ms 32.466 ms +1.0% no signal
Legacy 100,000-row insertion 253.700 ms 257.363 ms +0.1% no signal
Insertion with explicit input sizes 383.303 ms 388.043 ms +1.1% no signal
Joined aggregation queries 182.611 ms 178.760 ms -2.2% no signal
Large joined-result fetching 189.773 ms 193.996 ms +1.5% no signal
1.2-million-row fetching 3464.891 ms 3460.399 ms -0.5% no signal
Common table expression queries 5.292 ms 5.239 ms -1.1% no signal
256 KiB VARCHAR(MAX) / fetchall() 1.517 ms 1.320 ms -0.4% no signal
10,000 scalar values / fetchval() (debug disabled) 16.718 ms 16.590 ms -0.8% no signal
10,000 output-converted rows / fetchall() 19.327 ms 19.150 ms +0.0% no signal
10,000 output-converted rows / fetchmany(1000) 23.066 ms 22.993 ms +0.5% no signal
10,000 INT/NVARCHAR rows / fetchmany(1) 24.342 ms 24.180 ms -1.1% no signal
10,000 rows x 32 columns / dict(row._mapping) (warm) 31.394 ms 31.541 ms +0.5% no signal

Unix / SQL Server 2025

Database task Before After Paired change Result
Connection opening 81.710 ms 81.422 ms -0.1% no signal
SELECT queries 1.012 ms 0.993 ms -2.3% no signal
Row insertion 30.478 ms 30.282 ms -0.8% no signal
Executemany inserts 156.398 ms 156.761 ms +0.6% no signal
Fetch-all queries 121.457 ms 122.675 ms +1.0% no signal
Row-by-row fetching 5.051 ms 5.000 ms -1.0% no signal
Batched row fetching 119.786 ms 118.147 ms -0.3% no signal
Transaction commit and rollback 106.201 ms 105.962 ms -0.3% no signal
Arrow row fetching 90.501 ms 90.626 ms +0.1% no signal
100,000-row insertion 342.726 ms 346.612 ms +1.0% no signal
Row fetching in batches of 100 123.387 ms 122.917 ms -1.7% no signal
Row fetching in batches of 10,000 140.618 ms 132.047 ms -2.4% no signal
Repeated positional queries 31.305 ms 31.643 ms +0.9% no signal
Repeated named-parameter queries 31.812 ms 32.298 ms +0.6% no signal
Legacy 100,000-row insertion 260.314 ms 256.862 ms -1.2% no signal
Insertion with explicit input sizes 382.383 ms 383.473 ms +0.1% no signal
Joined aggregation queries 164.895 ms 165.129 ms +0.3% no signal
Large joined-result fetching 188.987 ms 189.187 ms +0.9% no signal
1.2-million-row fetching 3475.691 ms 3446.494 ms -0.6% no signal
Common table expression queries 5.035 ms 5.116 ms +1.9% no signal
256 KiB VARCHAR(MAX) / fetchall() 2.056 ms 1.530 ms -24.2% no signal
10,000 scalar values / fetchval() (debug disabled) 16.911 ms 16.976 ms -0.5% no signal
10,000 output-converted rows / fetchall() 19.851 ms 19.678 ms -1.7% no signal
10,000 output-converted rows / fetchmany(1000) 23.802 ms 23.429 ms -1.6% no signal
10,000 INT/NVARCHAR rows / fetchmany(1) 24.692 ms 24.537 ms -0.9% no signal
10,000 rows x 32 columns / dict(row._mapping) (warm) 31.325 ms 31.840 ms -1.6% no signal
Build and measurement details

ADO build 193170

PR head: 9f9ccc3700699e80f5baef5a552ff0b007f9a9bb
Base: 6907546ebb2eab52341eafc4d1cad2e45333735e
Measured merge: c724695a5d788a830a7fde1fb54bafd2679d138c

  • Unix / SQL Server 2022: Python 3.12.3, x86_64, SQL 16.0.4325.4; 5 paired comparisons and 1 warmup.
  • Unix / SQL Server 2025: Python 3.12.3, x86_64, SQL 17.0.5065.9; 5 paired comparisons and 1 warmup.

A consistent change requires more than 20% median paired movement, at least 1 ms between the median runtimes, and at least 80% of pairs exceeding the relative threshold in the same direction. A slowdown without enough pair agreement is reported as inconsistent.

The displayed change is the median of paired before-and-after ratios. It is not recalculated from the two displayed median runtimes.

Both revisions use profiling-enabled builds on the same agent and database, with alternating order and discarded warmups. Results are diagnostic and do not represent production-wheel latency.

Raw samples and logs are attached to the ADO run as profiler-* artifacts.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the switch to Quay images and added container-start retries.

No open issues 🎉

What changed in this PR

This PR restores Linux wheel image pulls on hosted 1ES agents by switching from GHCR imports to public PyPA images on Quay.

Changes:

  • Uses Quay for both manylinux and musllinux images while preserving image variants and architecture selection.
  • Adds up to five retries to the container-start task for transient failures.
File Description
OneBranchPipelines/​stages/​build-linux-single-stage.yml Switches image sources to Quay, updates explanatory comments, and adds container-start retries.

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

📊 Code Coverage Report

🔥 Diff Coverage

100%


🎯 Overall Coverage

86%


📈 Total Lines Covered: 11690 out of 13576
📁 Project: mssql-python


Diff Coverage

Diff: main...HEAD, staged and unstaged changes

No lines with coverage information in this diff.


📋 Files Needing Attention

📉 Files with overall lowest coverage (click to expand)
mssql_python.pybind.performance_counter.hpp: 0.7%
mssql_python.pybind.logger_bridge.cpp: 57.9%
mssql_python.pybind.ddbc_bindings.h: 64.5%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python._native_fetch.py: 77.7%
mssql_python.__init__.py: 80.8%
mssql_python.pybind.ddbc_bindings.cpp: 81.4%
mssql_python.pybind.row_mapping_cache.hpp: 81.5%
mssql_python.pybind.connection.connection_pool.cpp: 82.5%
mssql_python.pybind.connection.connection.cpp: 83.1%

🔗 Quick Links

⚙️ Build Summary 📋 Coverage Details

View Azure DevOps Build

Browse Full Coverage Report

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 13:15
@bewithgaurav Gaurav Sharma (bewithgaurav) changed the title FIX: Restore Linux wheel image pulls FIX: Restore release package pipeline Nov 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Source inspection cannot verify hosted 1ES connectivity to Quay or Azure DevOps Official sentinel handling, so validation requires a queued release-package run on the affected pool.

No open issues 🎉

Review effort: Balanced

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 03:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the release-packaging changes.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 18, 2026 07:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Manifest checks and YAML previews do not verify Quay access, container startup, or successful wheel builds and tests across all four Linux targets on hosted 1ES agents.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 18, 2026 08:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the release-package pipeline changes.

No open issues 🎉

Review effort: Balanced

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 18, 2026 08:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the release-packaging pipeline changes.

No open issues 🎉

Review effort: Balanced

@jahnvi480
Jahnvi Thakkar (jahnvi480) merged commit d257fdd into main Nov 18, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-size: small Minimal code update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants