Repository navigation
CHORE: Bump setuptools from 84.0.0 to 84.1.0 in /conda - #901
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
PR Performance Report✅ No regression detectedNo consistent slowdowns detected across all 2 environments. 0 IMPROVEMENTS 0 SLOWDOWNS 2/2 ENVIRONMENTS Coverage: 2 of 2 environments completed. Advisory result; does not block merging. Performance diagnosticsPhase times are inclusive diagnostics and must not be added together. They identify where measured time changed, not why it changed. No affected phases or call-count changes were recorded. All database tasks and timingsUnix / SQL Server 2022
Unix / SQL Server 2025
Build and measurement detailsPR head:
A consistent change requires more than 20% median paired movement, at least 1 ms between the median runtimes, and at least 80% of pairs exceeding the relative threshold in the same direction. A slowdown without enough pair agreement is reported as inconsistent. The displayed change is the median of paired before-and-after ratios. It is not recalculated from the two displayed median runtimes. Both revisions use profiling-enabled builds on the same agent and database, with alternating order and discarded warmups. Results are diagnostic and do not represent production-wheel latency. Raw samples and logs are attached to the ADO run as |
There was a problem hiding this comment.
🟡 Changes recommended
The audit lock omits setuptools 84.1.0, so the workflow cannot reliably exercise the requested version and the regression test may use an unpinned runner copy or skip entirely.
1 open issue
What changed in this PR
This PR targets setuptools 84.1.0 for mssql-python’s Conda tooling, incorporating upstream archive and wheel-installation security fixes.
Changes:
- Updates the audit input pin from setuptools 84.0.0 to 84.1.0.
- Removes setuptools from both generated locks and changes platform-specific dependencies in the publisher lock.
| File | Description |
|---|---|
conda/requirements-publish.txt |
Changes platform-specific dependencies and removes setuptools. |
conda/requirements-audit.txt |
Removes the hashed setuptools entry. |
conda/requirements-audit.in |
Pins setuptools to 84.1.0 for audit tooling. |
Review effort: Balanced
Bumps [setuptools](https://github.com/pypa/setuptools) from 84.0.0 to 84.1.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst) - [Commits](pypa/setuptools@v84.0.0...v84.1.0) --- updated-dependencies: - dependency-name: setuptools dependency-version: 84.1.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
4048349 to
d219ef3
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The audit lock removes setuptools instead of pinning and hashing version 84.1.0, so CI does not apply the intended upgrade and may run the regression with an unpinned version or skip it entirely.
1 open issue
Review effort: Balanced
Pin setuptools 84.1.0 in both audit and publisher locks and preserve the reviewed Windows publisher dependency closure. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
/azp run MSSQL-Python-PR-Validation |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.performance_counter.hpp: 0.7%
mssql_python.pybind.logger_bridge.cpp: 57.9%
mssql_python.pybind.ddbc_bindings.h: 64.5%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python._native_fetch.py: 77.7%
mssql_python.__init__.py: 80.8%
mssql_python.pybind.ddbc_bindings.cpp: 81.4%
mssql_python.pybind.row_mapping_cache.hpp: 81.5%
mssql_python.pybind.connection.connection.cpp: 83.1%
mssql_python.pybind.connection.connection_pool.cpp: 83.7%🔗 Quick Links
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
/azp run MSSQL-Python-PR-Validation |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |

Work Item / Issue Reference
Summary
Upgrade setuptools from 84.0.0 to 84.1.0 in the Conda audit input and both hash-locked audit/publisher environments. Restore the missing audit lock entry and preserve the publisher's Windows dependency closure without unrelated package, hash, or marker changes.