Skip to content

CHORE: Bump setuptools from 84.0.0 to 84.1.0 in /conda - #901

Merged
Jahnvi Thakkar (jahnvi480) merged 5 commits into
mainfrom
dependabot/pip/conda/setuptools-84.1.0
Nov 18, 2026
Merged

Jahnvi Thakkar (jahnvi480) merged 5 commits into
mainfrom
dependabot/pip/conda/setuptools-84.1.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Work Item / Issue Reference

AB#47861

GitHub Issue: N/A


Summary

Upgrade setuptools from 84.0.0 to 84.1.0 in the Conda audit input and both hash-locked audit/publisher environments. Restore the missing audit lock entry and preserve the publisher's Windows dependency closure without unrelated package, hash, or marker changes.

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file python Pull requests that update python code labels Nov 17, 2026
Copilot AI balanced review requested due to automatic review settings November 17, 2026 03:05
@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

PR Performance Report

✅ No regression detected

No consistent slowdowns detected across all 2 environments.

0 IMPROVEMENTS 0 SLOWDOWNS 2/2 ENVIRONMENTS

Coverage: 2 of 2 environments completed. Advisory result; does not block merging.

Performance diagnostics

Phase times are inclusive diagnostics and must not be added together. They identify where measured time changed, not why it changed.

No affected phases or call-count changes were recorded.

All database tasks and timings

Unix / SQL Server 2022

Database task Before After Paired change Result
Connection opening 10.275 ms 10.314 ms +0.4% no signal
SELECT queries 1.011 ms 1.005 ms -0.6% no signal
Row insertion 30.528 ms 30.456 ms -0.1% no signal
Executemany inserts 161.996 ms 163.407 ms +0.9% no signal
Fetch-all queries 117.824 ms 117.771 ms +0.2% no signal
Row-by-row fetching 5.034 ms 4.917 ms -2.3% no signal
Batched row fetching 115.496 ms 115.839 ms -1.2% no signal
Transaction commit and rollback 105.705 ms 106.518 ms +0.0% no signal
Arrow row fetching 89.229 ms 90.310 ms +1.3% no signal
100,000-row insertion 342.045 ms 358.027 ms +0.4% no signal
Row fetching in batches of 100 122.382 ms 120.352 ms -1.9% no signal
Row fetching in batches of 10,000 128.816 ms 132.623 ms -2.4% no signal
Repeated positional queries 31.904 ms 31.901 ms +0.0% no signal
Repeated named-parameter queries 32.169 ms 32.258 ms +1.9% no signal
Legacy 100,000-row insertion 271.015 ms 253.725 ms -0.6% no signal
Insertion with explicit input sizes 382.308 ms 397.046 ms +2.7% no signal
Joined aggregation queries 194.709 ms 182.300 ms -7.1% no signal
Large joined-result fetching 186.243 ms 187.042 ms +1.1% no signal
1.2-million-row fetching 3496.373 ms 3472.896 ms -0.5% no signal
Common table expression queries 5.343 ms 5.366 ms +0.4% no signal
256 KiB VARCHAR(MAX) / fetchall() 1.557 ms 1.371 ms +1.8% no signal
10,000 scalar values / fetchval() (debug disabled) 16.959 ms 16.910 ms -0.6% no signal
10,000 output-converted rows / fetchall() 19.804 ms 19.239 ms -2.9% no signal
10,000 output-converted rows / fetchmany(1000) 24.780 ms 23.310 ms -5.9% no signal
10,000 INT/NVARCHAR rows / fetchmany(1) 24.906 ms 24.336 ms -3.2% no signal
10,000 rows x 32 columns / dict(row._mapping) (warm) 31.505 ms 31.360 ms -0.0% no signal

Unix / SQL Server 2025

Database task Before After Paired change Result
Connection opening 81.543 ms 80.605 ms -1.2% no signal
SELECT queries 1.054 ms 1.012 ms -1.4% no signal
Row insertion 30.830 ms 31.217 ms +0.5% no signal
Executemany inserts 156.780 ms 156.710 ms -0.3% no signal
Fetch-all queries 119.854 ms 121.472 ms +1.0% no signal
Row-by-row fetching 4.979 ms 5.073 ms +1.2% no signal
Batched row fetching 118.173 ms 117.889 ms -0.2% no signal
Transaction commit and rollback 107.946 ms 107.287 ms -0.6% no signal
Arrow row fetching 90.029 ms 89.755 ms -0.4% no signal
100,000-row insertion 349.026 ms 346.139 ms -1.0% no signal
Row fetching in batches of 100 141.237 ms 123.190 ms -7.0% no signal
Row fetching in batches of 10,000 126.934 ms 137.949 ms -0.4% no signal
Repeated positional queries 31.738 ms 31.694 ms +0.0% no signal
Repeated named-parameter queries 32.515 ms 32.368 ms -0.9% no signal
Legacy 100,000-row insertion 254.703 ms 255.231 ms +0.2% no signal
Insertion with explicit input sizes 386.631 ms 380.130 ms -1.6% no signal
Joined aggregation queries 170.828 ms 166.886 ms -0.9% no signal
Large joined-result fetching 188.146 ms 195.930 ms +3.2% no signal
1.2-million-row fetching 3486.790 ms 3503.866 ms +0.2% no signal
Common table expression queries 5.098 ms 5.147 ms -2.6% no signal
256 KiB VARCHAR(MAX) / fetchall() 1.986 ms 1.936 ms -2.5% no signal
10,000 scalar values / fetchval() (debug disabled) 16.975 ms 16.943 ms -0.2% no signal
10,000 output-converted rows / fetchall() 20.035 ms 19.620 ms -2.1% no signal
10,000 output-converted rows / fetchmany(1000) 24.225 ms 23.184 ms -5.4% no signal
10,000 INT/NVARCHAR rows / fetchmany(1) 24.832 ms 24.431 ms -2.2% no signal
10,000 rows x 32 columns / dict(row._mapping) (warm) 31.798 ms 32.163 ms +0.2% no signal
Build and measurement details

ADO build 193145

PR head: 24b867944108bac0775b69723ff290fe996b69e1
Base: 95d7e19cf06dc5aa8dde0c83193ccf055362aaa4
Measured merge: 71734ae1fd588da96c3f5676afd753952ebcc57d

  • Unix / SQL Server 2022: Python 3.12.3, x86_64, SQL 16.0.4325.4; 5 paired comparisons and 1 warmup.
  • Unix / SQL Server 2025: Python 3.12.3, x86_64, SQL 17.0.5065.9; 5 paired comparisons and 1 warmup.

A consistent change requires more than 20% median paired movement, at least 1 ms between the median runtimes, and at least 80% of pairs exceeding the relative threshold in the same direction. A slowdown without enough pair agreement is reported as inconsistent.

The displayed change is the median of paired before-and-after ratios. It is not recalculated from the two displayed median runtimes.

Both revisions use profiling-enabled builds on the same agent and database, with alternating order and discarded warmups. Results are diagnostic and do not represent production-wheel latency.

Raw samples and logs are attached to the ADO run as profiler-* artifacts.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The audit lock omits setuptools 84.1.0, so the workflow cannot reliably exercise the requested version and the regression test may use an unpinned runner copy or skip entirely.

1 open issue
What changed in this PR

This PR targets setuptools 84.1.0 for mssql-python’s Conda tooling, incorporating upstream archive and wheel-installation security fixes.

Changes:

  • Updates the audit input pin from setuptools 84.0.0 to 84.1.0.
  • Removes setuptools from both generated locks and changes platform-specific dependencies in the publisher lock.
File Description
conda/​requirements-publish.txt Changes platform-specific dependencies and removes setuptools.
conda/​requirements-audit.txt Removes the hashed setuptools entry.
conda/​requirements-audit.in Pins setuptools to 84.1.0 for audit tooling.

Review effort: Balanced

Comment thread conda/requirements-audit.in Resolved
Bumps [setuptools](https://github.com/pypa/setuptools) from 84.0.0 to 84.1.0.
- [Release notes](https://github.com/pypa/setuptools/releases)
- [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst)
- [Commits](pypa/setuptools@v84.0.0...v84.1.0)

---
updated-dependencies:
- dependency-name: setuptools
  dependency-version: 84.1.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/pip/conda/setuptools-84.1.0 branch from 4048349 to d219ef3 Compare November 18, 2026 00:38
Copilot AI balanced review requested due to automatic review settings November 18, 2026 00:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The compiled audit lock omits setuptools==84.1.0, so the workflow cannot install the intended version and the regression test may use an unpinned runner version or skip entirely.

1 open issue

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 18, 2026 02:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The audit lock removes setuptools instead of pinning and hashing version 84.1.0, so CI does not apply the intended upgrade and may run the regression with an unpinned version or skip it entirely.

1 open issue

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 18, 2026 04:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The generated audit requirements omit the setuptools 84.1.0 pin and hash, so the workflow does not apply the upgrade and the wheel regression test may skip or use an unpinned version.

1 open issue

Review effort: Balanced

Pin setuptools 84.1.0 in both audit and publisher locks and preserve the reviewed Windows publisher dependency closure.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 18, 2026 04:39
@github-actions github-actions Bot added the pr-size: small Minimal code update label Nov 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the setuptools dependency update.

1 open issue

Review effort: Balanced

@jahnvi480

Copy link
Copy Markdown
Contributor

/azp run MSSQL-Python-PR-Validation

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 1 pipeline(s).

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

📊 Code Coverage Report

🔥 Diff Coverage

100%


🎯 Overall Coverage

86%


📈 Total Lines Covered: 11694 out of 13576
📁 Project: mssql-python


Diff Coverage

Diff: main...HEAD, staged and unstaged changes

No lines with coverage information in this diff.


📋 Files Needing Attention

📉 Files with overall lowest coverage (click to expand)
mssql_python.pybind.performance_counter.hpp: 0.7%
mssql_python.pybind.logger_bridge.cpp: 57.9%
mssql_python.pybind.ddbc_bindings.h: 64.5%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python._native_fetch.py: 77.7%
mssql_python.__init__.py: 80.8%
mssql_python.pybind.ddbc_bindings.cpp: 81.4%
mssql_python.pybind.row_mapping_cache.hpp: 81.5%
mssql_python.pybind.connection.connection.cpp: 83.1%
mssql_python.pybind.connection.connection_pool.cpp: 83.7%

🔗 Quick Links

⚙️ Build Summary 📋 Coverage Details

View Azure DevOps Build

Browse Full Coverage Report

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 18, 2026 06:28
@jahnvi480

Copy link
Copy Markdown
Contributor

/azp run MSSQL-Python-PR-Validation

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 1 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The setuptools 84.1.0 dependency update has no active review issues.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@jahnvi480
Jahnvi Thakkar (jahnvi480) merged commit 6907546 into main Nov 18, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file pr-size: small Minimal code update python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants