fix(mcp): disable chromium sandbox on linux for undefined channel - #42466
Open
MOHAMMED WASIM KHAN (wasim-builds) wants to merge 1 commit into
Open
fix(mcp): disable chromium sandbox on linux for undefined channel#42466MOHAMMED WASIM KHAN (wasim-builds) wants to merge 1 commit into
MOHAMMED WASIM KHAN (wasim-builds) wants to merge 1 commit into
Conversation
Fixes microsoft#42452 Treats an undefined channel the same as 'chromium' and 'chrome-for-testing' when deciding the sandbox default on Linux in the MCP config. This ensures the bundled downloaded browser works out of the box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42452
When using MCP on Linux with the default bundled chromium (where
channelis undefined), the browser launch would fail withChromium sandboxing failed!.This PR treats an
undefinedchannel the same as'chromium'and'chrome-for-testing'when deciding thechromiumSandboxdefault for Linux invalidateBrowserConfig. This matches the behavior of the bundled browser in other launch contexts and ensures it works out of the box.