[heft-sass-plugin] Replace build-tests project with SassProcessor unit tests#5769
Merged
iclanton merged 2 commits intomicrosoft:mainfrom Apr 11, 2026
Merged
[heft-sass-plugin] Replace build-tests project with SassProcessor unit tests#5769iclanton merged 2 commits intomicrosoft:mainfrom
iclanton merged 2 commits intomicrosoft:mainfrom
Conversation
iclanton
requested review from
apostolisms,
bmiddha,
dmichon-msft,
jxanthony and
octogonz
as code owners
octogonz
approved these changes
Apr 11, 2026
iclanton
force-pushed
the
clean-up-tests
branch
from
c9b3995 to
35d1c08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
heft-sass-doNotTrimOriginalFileExtension-testbuild-test project, which tested only a singleSassProcessoroption via a full Heft buildSassProcessor.test.tsunit tests directly inheft-sass-plugin, covering CSS modules, Sass/SASS syntax, JS shims,doNotTrimOriginalFileExtension,preserveIcssExports,postProcessCssAsync, multiple output folders, error reporting, and moresrc/test/fixtures/and FileSystem writes are mocked, so no build pipeline is neededTest plan
rush build --to @rushstack/heft-sass-pluginpassesrush test --to @rushstack/heft-sass-pluginpasses with all new tests green🤖 Generated with Claude Code