.Net: Fix GeminiPromptExecutionSettings.Clone dropping Labels and CachedContent#14194
.Net: Fix GeminiPromptExecutionSettings.Clone dropping Labels and CachedContent#14194dfedoryshchev wants to merge 1 commit into
Conversation
|
@dfedoryshchev please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a correctness issue in the .NET Google Gemini connector where GeminiPromptExecutionSettings.Clone() previously dropped two serialized, user-settable properties (Labels and CachedContent), causing cloned settings to lose request metadata and explicit caching references.
Changes:
- Update
GeminiPromptExecutionSettings.Clone()to cloneLabels(as a new dictionary) and copyCachedContent. - Extend
PromptExecutionSettingsCloneWorksAsExpectedunit test to set and assert bothlabelsandcached_contentsurvive cloning.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs | Ensures Clone() preserves Labels and CachedContent (previously omitted). |
| dotnet/src/Connectors/Connectors.Google.UnitTests/GeminiPromptExecutionSettingsTests.cs | Adds assertions verifying the new clone behavior for Labels and CachedContent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Motivation and Context
GeminiPromptExecutionSettings.Clone()rebuilds the settings through an object initializer, but two settable, serialized properties are missing from it, so cloning silently drops them:Labels([JsonPropertyName("labels")])CachedContent([JsonPropertyName("cached_content")])Every other serialized property is copied in
Clone(); these two are not, so a clone loses the request labels and the explicit-cache reference.Description
Labels(as a new dictionary, matching howExtensionData/StopSequencesare cloned) andCachedContentinClone().PromptExecutionSettingsCloneWorksAsExpectedto set and assert both properties.Contribution Checklist