[BREAKING] Fix cross-worker settings consistency and Redis Explorer - #1478
Draft
Bionic711 wants to merge 3 commits into
Draft
[BREAKING] Fix cross-worker settings consistency and Redis Explorer#1478Bionic711 wants to merge 3 commits into
Bionic711 wants to merge 3 commits into
Conversation
Fixes #1477 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linked issue
Fixes #1477
Release Notes & Latest Features
Is this visible to end users?
Is this admin-facing (Admin Settings, governance, deployment, config)?
Should this become a Latest Feature card?
Screenshot needed for the card?
Release notes include the settings-consistency fix under v0.261.025, the Redis Explorer correction under v0.261.026, and the bootstrap import-boundary correction under v0.261.027.
Version bump
application/single_app/config.pyVERSIONthird segment bumped, or not needed because this is docs-onlydeployers/version.txtbumped, or not needed becausedeployers/was not changedApplication version: 0.261.024 -> 0.261.027. No deployer files changed.
Testing / validation
Validated against current
origin/Developmentbefore publication:application/single_app/*.pyfile covered by the GitHub workflow and changed tests.python scripts/check_swagger_routes.py <changed route files>: 7 route-owning files passed.python scripts/check_xss_sinks.py --full-file <changed application files>: 20 files passed.python scripts/check_broken_access_control.py --full-file <changed application Python files>: 19 files passed.git diff --checkand staged whitespace checks: passed.python -B -m pytest -q --disable-warnings -p no:cacheproviderwith the following isolated group: 155 passed, 1 skipped:functional_tests/test_app_settings_store_consistency.pyfunctional_tests/test_app_settings_auxiliary_writers.pyfunctional_tests/test_cosmos_wave2a_chat_bootstrap_cache.pyfunctional_tests/test_document_action_capability_settings.pyfunctional_tests/test_settings_secrets_exposure_hardening.pyfunctional_tests/test_public_workspace_display_name_settings.pyfunctional_tests/route_tests/.ui_tests/test_admin_settings_save_consistency.pytest_cosmos_wave5a3_redis_monitoring.py: 33 passed.CodeQL correction in 3faf396 / v0.261.027:
test_app_settings_import_boundaries.pychecks real cold imports, normal/-O startup probes with network/config imports blocked, and the full cache dependency graph.Known validation caveats accepted for this draft:
sys.modules["azure.identity"]without restoring it. Redis and application groups pass in separate processes; standalone regressions pass. No application workaround was added for this test-stub contamination.docs/_data/app_surface.ymldoes not. This unrelated file was left unchanged. Documentation site quality: 6/6 passed.Documentation
docs/admin/scale.mddocuments the new read/write behavior, Redis failure policy, interrupted-save handling, coordinated deployment/restart requirements, and current versus legacy Explorer keys. Regression docstrings document the deterministic failure scenarios. No separate new feature page or Latest Feature card is needed.Security checklist
@swagger_route(security=get_auth_security())sanitize_settings_for_user()No routes were added; changed route decorators and policy contracts passed validation. Existing frontend sanitization boundaries are retained. The admin revision field is escaped, and Explorer tests verify nested credentials and Cosmos session tokens remain redacted. No cloud configuration changes or deployments were performed by the PR-preparation workflow.