Fix settings error text legibility in High Contrast mode#20098
Open
SushaanthSrinivasan wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix settings error text legibility in High Contrast mode#20098SushaanthSrinivasan wants to merge 1 commit intomicrosoft:mainfrom
SushaanthSrinivasan wants to merge 1 commit intomicrosoft:mainfrom
Conversation
SystemErrorTextColor doesn't adapt to High Contrast themes, making the settings error text illegible. In HC mode, let the text inherit the system foreground from its parent element instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
@microsoft-github-policy-service agree |
carlos-zamora
approved these changes
Apr 10, 2026
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
Thank you so much for doing this! 🙏
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Demo (extracted from PR body)Before (HC White): After (HC White): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18147
SystemErrorTextColordoesn't adapt to High Contrast themes, so the error details in the "Failed to reload settings" dialog are illegible (yellow on cream in HC White, for example).Fix: skip the
ErrorTextBrushforeground override when High Contrast is active, letting the text inherit the system HC text color from its parent element. This matches the existing HC detection pattern used inTermControl.cppandMainPage.cpp.Validated manually on High Contrast White and Night sky themes.