Skip to content

Replace most ID usage with pointers#3362

Draft
jakebailey wants to merge 1 commit intomainfrom
jabaile/less-ids
Draft

Replace most ID usage with pointers#3362
jakebailey wants to merge 1 commit intomainfrom
jabaile/less-ids

Conversation

@jakebailey
Copy link
Copy Markdown
Member

We don't need IDs for comparability in Go; we can use the pointer in pretty much all cases, saving loads.

@jakebailey
Copy link
Copy Markdown
Member Author

@typescript-bot perf test this faster

@typescript-bot
Copy link
Copy Markdown

typescript-bot commented Apr 8, 2026

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Copy Markdown

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - native
Errors 4 4 ~ ~ ~ p=1.000 n=6
Symbols 81,815 (± 0.02%) 81,804 (± 0.02%) ~ 81,781 81,827 p=0.332 n=6
Types 98,821 98,821 ~ ~ ~ p=1.000 n=6
Memory Used 174,707k (± 0.03%) 174,816k (± 0.06%) +109k (+ 0.06%) 174,712k 175,005k p=0.031 n=6
Memory Allocs 1,771,567 (± 0.02%) 1,762,352 (± 0.02%) -9,215 (- 0.52%) 1,761,825 1,762,807 p=0.005 n=6
Config Time 0.000s 0.000s ~ ~ ~ p=1.000 n=6
Parse Time 0.059s (± 5.50%) 0.059s (± 6.44%) ~ 0.055s 0.064s p=0.935 n=6
Bind Time 0s 0s ~ ~ ~ p=1.000 n=6
Check Time 0s 0s ~ ~ ~ p=1.000 n=6
Emit Time 0.854s (± 0.62%) 0.843s (± 1.41%) ~ 0.834s 0.863s p=0.173 n=6
Total Time 0.914s (± 0.74%) 0.902s (± 1.71%) ~ 0.889s 0.927s p=0.229 n=6
angular-1 - native
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 884,654 (± 0.12%) 884,833 (± 0.07%) ~ 883,750 885,449 p=1.000 n=6
Types 263,842 (± 0.00%) 263,842 (± 0.00%) ~ 263,840 263,845 p=0.654 n=6
Memory Used 835,729k (± 0.06%) 836,217k (± 0.09%) ~ 835,042k 837,532k p=0.230 n=6
Memory Allocs 6,716,687 (± 0.23%) 6,712,236 (± 0.11%) ~ 6,697,659 6,717,634 p=0.689 n=6
Config Time 0.028s (± 2.70%) 0.028s (± 3.04%) ~ 0.027s 0.029s p=0.432 n=6
Parse Time 0.246s (± 5.83%) 0.241s (± 6.30%) ~ 0.218s 0.259s p=0.873 n=6
Bind Time 0s 0s ~ ~ ~ p=1.000 n=6
Check Time 0s 0s ~ ~ ~ p=1.000 n=6
Emit Time 1.896s (± 1.05%) 1.917s (± 0.78%) ~ 1.893s 1.935s p=0.078 n=6
Total Time 2.172s (± 1.25%) 2.188s (± 0.70%) ~ 2.167s 2.209s p=0.261 n=6
mui-docs - native
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 4,262,286 4,262,286 ~ ~ ~ p=1.000 n=6
Types 1,537,275 1,537,275 ~ ~ ~ p=1.000 n=6
Memory Used 5,420,081k (± 0.04%) 5,443,848k (± 0.07%) +23,767k (+ 0.44%) 5,439,652k 5,448,579k p=0.005 n=6
Memory Allocs 101,039,389 (±20.35%) 96,925,070 (±15.78%) ~ 73,687,323 110,824,668 p=0.936 n=6
Config Time 0.022s (± 3.39%) 0.022s (± 2.38%) ~ 0.021s 0.022s p=0.241 n=6
Parse Time 1.135s (±33.33%) 1.011s (±20.31%) ~ 0.688s 1.249s p=0.471 n=6
Bind Time 0.002s 0.002s ~ ~ ~ p=1.000 n=6
Check Time 16.780s (± 0.23%) 16.758s (± 0.36%) ~ 16.694s 16.864s p=0.298 n=6
Emit Time 0.508s (±28.39%) 0.439s (± 3.94%) ~ 0.416s 0.453s p=0.297 n=6
Total Time 18.775s (± 1.74%) 18.641s (± 1.33%) ~ 18.202s 18.898s p=0.873 n=6
self-build-src - native
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,396,619 1,396,619 ~ ~ ~ p=1.000 n=6
Types 442,163 442,163 ~ ~ ~ p=1.000 n=6
Memory Used 1,634,649k (± 0.30%) 1,633,877k (± 0.26%) ~ 1,625,447k 1,636,915k p=0.575 n=6
Memory Allocs 57,251,727 (± 0.13%) 57,273,372 (± 0.09%) ~ 57,193,000 57,328,680 p=0.810 n=6
Config Time 0.018s (±49.85%) 0.014s (±58.23%) ~ 0.006s 0.029s p=0.470 n=6
Parse Time 0.278s (± 5.04%) 0.278s (± 1.54%) ~ 0.273s 0.285s p=0.936 n=6
Bind Time 0.000s 0.000s ~ ~ ~ p=1.000 n=6
Check Time 2.315s (± 1.22%) 2.299s (± 0.69%) ~ 2.269s 2.313s p=0.298 n=6
Emit Time 0.224s (± 8.04%) 0.220s (± 3.00%) ~ 0.208s 0.225s p=1.000 n=6
Total Time 29.639s (± 1.34%) 29.478s (± 0.58%) ~ 29.257s 29.699s p=0.471 n=6
self-compiler - native
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 338,176 338,176 ~ ~ ~ p=1.000 n=6
Types 199,525 199,525 ~ ~ ~ p=1.000 n=6
Memory Used 330,497k (± 0.04%) 330,835k (± 0.04%) +338k (+ 0.10%) 330,635k 330,987k p=0.005 n=6
Memory Allocs 2,552,153 (± 0.03%) 2,551,737 (± 0.04%) ~ 2,550,932 2,553,602 p=0.378 n=6
Config Time 0.001s 0.001s (±34.96%) ~ 0.001s 0.002s p=0.405 n=6
Parse Time 0.133s (± 3.89%) 0.138s (± 4.58%) ~ 0.129s 0.147s p=0.199 n=6
Bind Time 0.000s 0.000s ~ ~ ~ p=1.000 n=6
Check Time 1.378s (± 0.45%) 1.379s (± 0.64%) ~ 1.365s 1.391s p=0.873 n=6
Emit Time 0.081s (± 4.41%) 0.082s (±10.96%) ~ 0.072s 0.097s p=0.747 n=6
Total Time 1.649s (± 0.40%) 1.652s (± 0.86%) ~ 1.637s 1.672s p=0.872 n=6
ts-pre-modules - native
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 752 752 ~ ~ ~ p=1.000 n=6
Types 356 356 ~ ~ ~ p=1.000 n=6
Memory Used 103,313k (± 0.03%) 103,308k (± 0.04%) ~ 103,276k 103,379k p=0.689 n=6
Memory Allocs 111,128 (± 0.43%) 110,651 (± 0.30%) ~ 110,295 111,235 p=0.093 n=6
Config Time 0.001s (±48.94%) 0.001s (±77.38%) ~ 0.000s 0.001s p=0.595 n=6
Parse Time 0.122s (± 5.85%) 0.119s (± 5.61%) ~ 0.111s 0.128s p=0.688 n=6
Bind Time 0s 0s ~ ~ ~ p=1.000 n=6
Check Time 0s 0s ~ ~ ~ p=1.000 n=6
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=6
Total Time 0.123s (± 5.81%) 0.120s (± 5.45%) ~ 0.112s 0.129s p=0.688 n=6
vscode - native
Errors 193 193 ~ ~ ~ p=1.000 n=6
Symbols 6,058,532 6,058,532 ~ ~ ~ p=1.000 n=6
Types 2,289,675 2,289,675 ~ ~ ~ p=1.000 n=6
Memory Used 4,113,456k (± 0.03%) 4,121,967k (± 0.03%) +8,511k (+ 0.21%) 4,120,055k 4,123,338k p=0.005 n=6
Memory Allocs 29,865,138 (± 0.05%) 29,853,017 (± 0.03%) ~ 29,840,400 29,868,418 p=0.128 n=6
Config Time 0.125s (± 9.62%) 0.122s (± 8.57%) ~ 0.107s 0.135s p=0.630 n=6
Parse Time 0.718s (± 1.59%) 0.695s (± 3.02%) 🟩-0.023s (- 3.23%) 0.657s 0.712s p=0.045 n=6
Bind Time 0.108s (± 2.31%) 0.116s (±12.74%) ~ 0.107s 0.146s p=0.125 n=6
Check Time 8.140s (± 0.47%) 8.160s (± 0.56%) ~ 8.117s 8.242s p=0.575 n=6
Emit Time 2.002s (± 2.30%) 1.993s (± 8.00%) ~ 1.678s 2.109s p=0.471 n=6
Total Time 11.114s (± 0.58%) 11.109s (± 0.91%) ~ 10.925s 11.206s p=0.936 n=6
webpack - native
Errors 1,146 1,146 ~ ~ ~ p=1.000 n=6
Symbols 699,634 699,634 ~ ~ ~ p=1.000 n=6
Types 334,753 334,753 ~ ~ ~ p=1.000 n=6
Memory Used 550,493k (± 0.03%) 551,307k (± 0.03%) +814k (+ 0.15%) 551,118k 551,511k p=0.005 n=6
Memory Allocs 4,217,238 (± 0.07%) 4,233,308 (± 0.45%) +16,070 (+ 0.38%) 4,218,739 4,270,951 p=0.013 n=6
Config Time 0.014s (±15.72%) 0.012s (±14.14%) ~ 0.010s 0.014s p=0.157 n=6
Parse Time 0.144s (± 4.10%) 0.145s (± 4.31%) ~ 0.139s 0.156s p=0.810 n=6
Bind Time 0.030s (±26.69%) 0.032s (±25.68%) ~ 0.022s 0.044s p=0.574 n=6
Check Time 1.141s (± 1.02%) 1.145s (± 0.59%) ~ 1.134s 1.155s p=0.630 n=6
Emit Time 0.001s (±34.96%) 0.001s (±38.69%) ~ 0.001s 0.002s p=0.595 n=6
Total Time 1.351s (± 0.97%) 1.357s (± 0.56%) ~ 1.348s 1.366s p=0.377 n=6
xstate-main - native
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 991,165 991,165 ~ ~ ~ p=1.000 n=6
Types 350,724 350,724 ~ ~ ~ p=1.000 n=6
Memory Used 599,925k (± 0.01%) 601,741k (± 0.02%) +1,816k (+ 0.30%) 601,676k 601,951k p=0.005 n=6
Memory Allocs 4,957,136 (± 0.23%) 4,943,936 (± 0.09%) -13,201 (- 0.27%) 4,939,110 4,950,852 p=0.013 n=6
Config Time 0.007s (±27.08%) 0.008s (±18.77%) ~ 0.005s 0.009s p=0.616 n=6
Parse Time 0.137s (± 6.24%) 0.136s (± 2.90%) ~ 0.132s 0.141s p=0.871 n=6
Bind Time 0.038s (±19.89%) 0.032s (±21.86%) ~ 0.025s 0.042s p=0.065 n=6
Check Time 1.122s (± 0.65%) 1.136s (± 1.40%) ~ 1.116s 1.150s p=0.148 n=6
Emit Time 0.001s 0.001s ~ ~ ~ p=1.000 n=6
Total Time 1.308s (± 0.86%) 1.316s (± 0.71%) ~ 1.299s 1.324s p=0.173 n=6
System info unknown
Hosts
  • native
Scenarios
  • Compiler-Unions - native
  • angular-1 - native
  • mui-docs - native
  • self-build-src - native
  • self-compiler - native
  • ts-pre-modules - native
  • vscode - native
  • webpack - native
  • xstate-main - native
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants