Fix index out of bounds panic in setLastNonTriviaPosition for empty strings#3375
Draft
Fix index out of bounds panic in setLastNonTriviaPosition for empty strings#3375
Conversation
Add bounds check to the trailing whitespace loop in setLastNonTriviaPosition to prevent index out of bounds panic when called with an empty string. In TypeScript, `s.charCodeAt(s.length - i - 1)` returns NaN for empty strings, causing isWhiteSpaceLike to return false and the loop to exit. In Go, indexing an empty string causes a panic, so we need an explicit bounds check. Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/52c89341-0a45-4f62-bb72-8145a17ef845 Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code action crash from setLastNonTriviaPosition
Fix index out of bounds panic in setLastNonTriviaPosition for empty strings
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setLastNonTriviaPositionpanics when called with an empty string viaWriteLiteral("")during code action JSX text emission. The trailing whitespace loop accessess[len(s)-i-1]without a bounds check — in TypeScript,charCodeAt(-1)returnsNaNwhich exits the loop naturally; Go panics.Fix: Add
i < len(s)guard to the loop condition:internal/printer/changetrackerwriter.go— bounds check on trailing whitespace loopinternal/printer/changetrackerwriter_test.go— unit tests for empty and all-whitespace stringsinternal/fourslash/tests/importFixJsxNoCrash_test.go— fourslash test exercising import fix on JSX