Fix nil pointer dereference in explainRedirectAndImpliedFormat#3380
Draft
Fix nil pointer dereference in explainRedirectAndImpliedFormat#3380
Conversation
…ource file not found Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/dbf27f2f-19ac-4356-bb00-70aa15ecfceb Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix nil pointer dereference during diagnostics request
Fix nil pointer dereference in explainRedirectAndImpliedFormat
Apr 9, 2026
Member
|
@copilot try to figure out a test case for this. |
…dFormat Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/07018514-60b1-489a-9f1f-f4794a3d06ec Co-authored-by: DanielRosenwasser <972891+DanielRosenwasser@users.noreply.github.com>
Contributor
Author
Added a test in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
explainRedirectAndImpliedFormatpanics whenGetSourceFileByPathreturns nil for a given path. The nil*ast.SourceFileis assigned to theast.HasFileNameinterface, then.Path()is called on it.GetSourceFileByPath, returning nil (empty diagnostics) early when the source file isn't found/src/MyFile.tsand/src/myFile.ts) where only one exists, triggering a file casing diagnostic whose file path references the missing file