fix(compiler): install VS Code/VS extensions from marketplace instead of npm#11169
Draft
timotheeguerin wants to merge 2 commits into
Draft
fix(compiler): install VS Code/VS extensions from marketplace instead of npm#11169timotheeguerin wants to merge 2 commits into
timotheeguerin wants to merge 2 commits into
Conversation
… of npm `tsp code install` now delegates to `code --install-extension microsoft.typespec-vscode` and `tsp vs install` downloads the latest vsix from the Visual Studio Marketplace, removing the dependency on the `typespec-vscode`/`typespec-vs` npm packages. Fixes part of #11168
microsoft-github-policy-service
Bot
added
the
compiler:core
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #11168.
The
tsp code installandtsp vs installCLI commands previously installed the editor extensions by downloading thetypespec-vscode/typespec-vsnpm packages, extracting the bundled.vsix, and installing that. Those npm packages only exist as a distribution vehicle and are now redundant since both extensions are published to their marketplaces.Changes
tsp code installnow delegates directly tocode --install-extension microsoft.typespec-vscode(respecting--insiders). No npm download.tsp vs installkeeps the "download a.vsix, then runVSIXInstaller.exe" flow, but downloads the latest vsix from the Visual Studio Marketplace instead of npm (via the galleryextensionquery+vspackageendpoints).install-vsix.ts; addeddownload-vsix.ts(marketplace query + download to temp dir + install callback + cleanup, with aTYPESPEC_DEBUG_VSIXlocal override for debugging).vsix-download-faileddiagnostic.Tests
test/cli/vscode.test.ts: install/uninstall invokecode/code-insiders --install-extension microsoft.typespec-vscode;vscode-in-pathdiagnostic whencodeis missing.test/cli/download-vsix.test.ts: version resolution + vspackage URL, temp cleanup,TYPESPEC_DEBUG_VSIXoverride, and download-failure diagnostics.Notes
Fully retiring/unpublishing the
typespec-vscode/typespec-vsnpm packages and their publish pipelines (also part of #11168) is left as a follow-up; this PR removes the CLI's runtime dependency on them.