Repository navigation
test: characterize settings contract and real stdio lifecycle (S2) - #134
Merged
Eduardo Villalpando Mello (edvilme) merged 1 commit intoNov 11, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
10 tasks
Contributor
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
Contributor
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Podman machine 'pyrx-automation' is not running. Test runs: none recorded. |
Rich Chiodo (rchiodo)
approved these changes
Nov 11, 2026
Rich Chiodo (rchiodo)
left a comment
Contributor
There was a problem hiding this comment.
Approved via Review Center.
Eduardo Villalpando Mello (edvilme)
merged commit Nov 11, 2026
f99929b
into
main
23 of 24 checks passed
Eduardo Villalpando Mello (edvilme)
deleted the
test/s2-settings-contract
branch
November 11, 2026 23:22
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #132.
initializationOptions. Both the TypeScript producer tests and Python consumer tests read the sameproducer.json; a partial legacy payload captures Python-only compatibility behavior.workspace_settings/global_settingsaliases across real in-processInitializeParamsapplications, retained roots/keys, replacement values, and matched lookups returning stored objects. No per-workspace identity guarantee is introduced.CONTRIBUTING.md.Preserved behavior / scope
No production code, serialized wire shape, dependency/lockfile, workflow (including S1), version, or consumer policy changes. Workspace/global/Python fallback contexts remain distinct; global
workspaceremains a plain path; merges remain shallow and unknown global keys are not automatically propagated. Repeated helper application is tested in-process, never as a second initialize request on a live session.The fixture endpoint exists only under
python/tests/fixtures/. No formatter/linter installation, tool process, daemon, network, VS Code host, or cross-runner Node/Python launch dependency is required by these tests. Later settings/facade and process-manager refactors remain out of scope.Validation
Validated on Windows with Python 3.13.14 and isolated Node 24.17.0 (matching
.nvmrc). Python imports were explicitly bound to this worktree withPYTHONPATH; the isolated nox environment used pygls 2.1.1 / lsprotocol 2025.0.0, and the subprocess fixture verifies both parent and child source provenance.test_server.py+test_server_stdio.pypython -m nox -s tests lintpython -m nox -r -s lintwithPYTHONUTF8=1,PYTHONIOENCODING=utf-8npm --prefix .\typescript testnpm --prefix .\typescript run buildnpm --prefix .\typescript run lintsrc/vscodeapi.tsgit diff --checkOther Python versions and Linux were not run locally; the existing CI matrix remains authoritative. The source-wide TS format check was intentionally not rerun or cleaned up: issue #132 records 14 pre-existing failures, and no TS production source changed.