Use language-client providers for Call Hierarchy and Workspace Symbols - #14772
Open
Colen Garoutte-Carson (Colengms) wants to merge 3 commits into
Open
Colen Garoutte-Carson (Colengms) wants to merge 3 commits into
Colen Garoutte-Carson (Colengms) wants to merge 3 commits into
Conversation
Colen Garoutte-Carson (Colengms)
marked this pull request as ready for review
September 15, 2026 20:27
Colen Garoutte-Carson (Colengms)
requested a review
from a team
as a code owner
September 15, 2026 20:27
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
September 15, 2026 22:56
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Server-initiated incoming-call cancellation no longer records the preserved cancellation telemetry.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced
Findings: 1
Open (1)
What changed in this PR
Replaces custom Call Hierarchy and Workspace Symbol providers with standard LSP-backed language-client providers while retaining presentation and telemetry middleware.
Changes:
- Removes custom provider registrations and protocol types.
- Adds standard Call Hierarchy request helpers.
- Preserves symbol localization and Call Hierarchy UI behavior through middleware.
| File | Description |
|---|---|
workspaceSymbolProvider.ts |
Removes the custom workspace-symbol provider. |
callHierarchyProvider.ts |
Removes the custom Call Hierarchy provider. |
protocolFilter.ts |
Adds middleware for presentation, cancellation, and telemetry. |
goToDefinition.ts |
Relocates the definition helper. |
extension.ts |
Updates helper imports. |
client.ts |
Removes custom provider registration and protocol declarations. |
callHierarchy.ts |
Adds standard LSP Call Hierarchy helpers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
September 16, 2026 02:45
View session
Sean McManus (sean-mcmanus)
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The extension manually registered Call Hierarchy and Workspace Symbol providers that used cpptools-specific protocol methods. The native language server now advertises and implements the corresponding standard LSP capabilities for both cpptools and mscppls.
This change:
WorkspaceSymbol.data.Providersdirectory.Providers, since it is an internal command helper rather than a registered provider.No user-facing behavior is intended to change.
Validation:
npm run compilenpm run lintCompatibility:
This PR requires the companion native change. It should ship with a matching cpptools binary that advertises the standard capabilities and no longer exposes the replaced custom methods.