Revert PR #1527: remove one-time defaultEnvManager User-settings migration#1612
Draft
Copilot wants to merge 1 commit into
Draft
Revert PR #1527: remove one-time defaultEnvManager User-settings migration#1612Copilot wants to merge 1 commit into
defaultEnvManager User-settings migration#1612Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
Revert PR #1527: remove one-time defaultEnvManager User-settings migration
Revert PR #1527: remove one-time Jun 25, 2026
defaultEnvManager User-settings migration
Copilot created this pull request from a session on behalf of
eleanorjboyd
June 25, 2026 02:46
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverses #1527, the activation-time migration that cleared
python-envs.defaultEnvManager: ms-python.python:systemfrom User settings.Changes
src/extension.ts— drop themigrateGlobalDefaultEnvManagerSettingimport and its awaited call inactivate().src/features/settings/settingHelpers.ts— deletemigrateGlobalDefaultEnvManagerSetting, theuserScopeHasValuehelper,MIGRATION_KEY, and the imports that become unused (SYSTEM_MANAGER_ID,getGlobalPersistentState,EventNames,sendTelemetryEvent).src/common/telemetry/constants.ts— remove theMIGRATION_SYSTEM_ENV_MANAGERenum entry and its GDPR/property mapping.src/test/features/settings/settingHelpers.unit.test.ts— remove the migration test suite plus thepersistentState/sendertest imports, and restore the originalsetEnvironmentManager - Global Settingssuite split that one time mitigation of unintentional setting saved to user settings #1527 collapsed.Net: +5 / −349 across 4 files, mirroring #1527's original additions. The persistent-state flag
globalSettingsMigration.systemEnvManagerRemovedis intentionally not cleaned up — it's a one-time boolean and harmless to leave behind on users who already ran the migration.