Localized voice previews for Voice Mode onboarding - #328259
Open
meganrogge wants to merge 2 commits into
Open
Conversation
For the languages Voice Mode speaks natively (de, es, fr, it, ja, ko, pt, zh) the onboarding card now previews that language's single voice instead of the four English options - choosing between the English voices is not meaningful there. English and languages without a native voice keep the four-voice chooser. Fixes #328084 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds locale-specific voice previews to Voice Mode onboarding.
Changes:
- Shows one native voice for eight supported languages.
- Retains the four-voice chooser for English and unsupported locales.
- Adds table-driven locale/sample tests.
Show a summary per file
| File | Description |
|---|---|
voiceModeOnboarding.ts |
Resolves spoken language and renders localized previews. |
voiceModeOnboarding.test.ts |
Tests locale-specific option counts and samples. |
Review details
- Files reviewed: 2/10 changed files
- Comments generated: 2
- Review effort level: Medium
Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
roblourens
approved these changes
Jul 30, 2026
dmitrivMS
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #328084
For the languages Voice Mode speaks natively (de, es, fr, it, ja, ko, pt, zh), the onboarding card now previews that language's single voice instead of the four English options — choosing between the English voices isn't meaningful in those locales. English and any locale without a native voice keep the four-voice chooser.
Behavior
Language resolution mirrors the voice client: an explicit override, then
agents.voice.language(unlessauto), then the window language.Notes
Validation
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com