Harden cache expiry notification logic - #328301
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens prompt-cache expiry tracking and notifications across resumed sessions and model changes.
Changes:
- Notify precisely at cache expiration.
- Restore and reconcile cache metadata from SDK usage metrics.
- Expand expiry, resume, and model-switch tests.
Show a summary per file
| File | Description |
|---|---|
agentHostPromptCacheNotification.test.ts |
Updates exact-expiry tests. |
agentHostPromptCacheNotification.ts |
Removes the expiration grace period. |
copilotAgentSession.test.ts |
Adds cache restoration and transition coverage. |
copilotAgentSession.ts |
Reconciles cache state with usage metrics. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
roblourens
previously approved these changes
Jul 30, 2026
…adillo # Conflicts: # src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts
The Copilot client-tool E2E capture has no cacheExpiresAt, so the old code called _setPromptCacheState(undefined) on every main-agent usage event and unconditionally wrote session meta, emitting two no-op session/metaChanged actions. Those writes are now deduped, so drop the entries from the snapshot. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a85f27d-5a24-405c-bc70-5fd820001e64
Giuspepe
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.