Improve notification handling to reduce duplicates - #328304
Merged
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @benibenjMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Consolidates rapidly duplicated notifications before toast rendering, reducing UI spam.
Changes:
- Adds pending-toast scheduling and duplicate replacement.
- Integrates pending-toast cleanup into notification lifecycle.
- Adds coverage for duplicates, spam limits, and removals.
Show a summary per file
| File | Description |
|---|---|
pendingNotificationToasts.ts |
Manages deferred toast rendering and deduplication. |
notificationsToasts.ts |
Integrates pending-toast handling. |
notificationsToasts.test.ts |
Tests pending notification behavior. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
benibenj
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new
PendingNotificationToastsclass to manage rapidly added notifications, ensuring that duplicate notifications are consolidated into a single toast. This change optimizes the rendering process and prevents spammy notifications from overwhelming the user interface. Tests validate the new behavior.fixes #328209