Try fix flaky tests - #328312
Merged
Merged
Conversation
…ut a draft `_createNewSession` installed its `onDidChangeSessionTypes` retry listener only after awaiting `openNewSession`. When a provider started serving the folder during that await (e.g. the local agent host finishing its handshake on a cold start), the change fired into the gap and was lost, so the composer kept no draft and the harness picker stayed hidden forever. Watch for the change from before the await and replay it once the durable listener is installed. Fixes the dominant failure in #328281.
The smoke runner deletes `.build/logs/smoke-tests-electron` on startup, so each iteration wipes the previous one and the published artifact only ever contains the last of 20 runs. A failure in any earlier iteration is therefore undiagnosable: no renderer/exthost/agenthost logs, screenshots or traces. Move the log directory aside on a failing iteration so the next run cannot reclaim the name. Only failing iterations are kept, so the artifact stays small. Refs #328281.
Contributor
There was a problem hiding this comment.
Pull request overview
Improves flaky smoke-test diagnostics and closes a provider-registration race in the Agents window.
Changes:
- Replays session-type changes missed during asynchronous session creation.
- Preserves failed smoke-test logs across iterations on all platforms.
- Retains original smoke-test exit statuses.
Show a summary per file
| File | Description |
|---|---|
src/vs/sessions/contrib/chat/browser/newChatWidget.ts |
Handles provider changes during session creation. |
build/azure-pipelines/win32/product-smoke-flaky-win32.yml |
Archives failed Windows iteration logs. |
build/azure-pipelines/linux/product-smoke-flaky-linux.yml |
Archives failed Linux iteration logs. |
build/azure-pipelines/darwin/product-smoke-flaky-darwin.yml |
Archives failed macOS iteration logs. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 4
- Review effort level: Balanced
alexr00
marked this pull request as ready for review
July 31, 2026 07:03
alexr00
enabled auto-merge (squash)
July 31, 2026 07:03
alexr00
approved these changes
Jul 31, 2026
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=460334
Fixes #328281