[cherry-pick] sessions: align list row hover feedback - #336983
Closed
vs-code-engineering[bot] wants to merge 1 commit into
Closed
vs-code-engineering[bot] wants to merge 1 commit into
vs-code-engineering[bot] wants to merge 1 commit into
Conversation
vs-code-engineering
Bot
added
the
cherry-pick-artifact
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved conflicts and missing backported APIs prevent compilation and validation.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 5
Open (5)
What changed in this PR
Aligns Sessions list-row hover feedback across row types while preserving spacing and layout behavior.
Changes:
- Updates row geometry, classes, and hover styling.
- Adds regression tests and screenshot baselines.
| File | Description |
|---|---|
| test/componentFixtures/blocks-ci-screenshots.md | Updates visual-test baselines. |
| src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts | Adds row-layout regression tests. |
| src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts | Adjusts row classes and heights. |
| src/vs/sessions/contrib/sessions/browser/media/sessionsList.css | Aligns hover geometry and spacing. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| height: 100%; | ||
| min-height: 0; | ||
|
|
||
| <<<<<<< HEAD |
Comment on lines
+347
to
+350
| <<<<<<< HEAD | ||
| if (isSessionSection(element) || isSessionGroupItem(element)) { | ||
| ======= | ||
| if (isSessionSection(element) && element.id === SESSIONS_HEADER_SECTION_ID) { |
| class SessionGroupRenderer implements ITreeRenderer<SessionListItem, FuzzyScore, ISessionGroupTemplate> { | ||
| static readonly TEMPLATE_ID = 'session-group'; | ||
| readonly templateId = SessionGroupRenderer.TEMPLATE_ID; | ||
| readonly rowClassName = 'session-list-section-row'; |
Comment on lines
+517
to
+519
| <<<<<<< HEAD | ||
| ======= | ||
| suite('shortcut entries', () => { |
|  | ||
|
|
||
| #### sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/Dark | ||
| <<<<<<< HEAD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #336953 from
main.<<<<<<</=======/>>>>>>>) are committed to the branch — check it out locally, resolve, and force-push.Conflicting files:
src/vs/sessions/contrib/sessions/browser/media/sessionsList.csssrc/vs/sessions/contrib/sessions/browser/views/sessionsList.tssrc/vs/sessions/contrib/sessions/test/browser/sessionsList.test.tstest/componentFixtures/blocks-ci-screenshots.mdAligns hover feedback across Sessions list rows so sessions, workspace folders, custom groups, shortcuts, and show-more rows use the same full-width square background.
Preserves the intended content spacing for section labels and show-more separators, and reserves the row-spacing height for shortcut entries. Adds regression coverage for row classes, geometry, and padding.
Validation:
npm run compilenpm run hygiene./scripts/test.sh --run src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts(145 passing)