chore(main): Exclude kiota-dom-export.txt from builds#1488
Open
Fryguy wants to merge 1 commit into
Open
Conversation
Fryguy
force-pushed
the
exclude-kiota-dom-export
branch
from
8233b9c to
408ea94
Compare
kiota-dom-export.txt is not needed at runtime and is a very large file (~32MB), contributing to a bloated package.
Fryguy
force-pushed
the
exclude-kiota-dom-export
branch
from
408ea94 to
f03a881
Compare
Fryguy
changed the title
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Reduces distribution/package size by excluding a large, non-runtime text artifact (kiota-dom-export.txt) from Flit packaging inputs (per #1287).
Changes:
- Add Flit sdist exclusion for
msgraph/generated/kiota-dom-export.txt
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+47
to
+48
| [tool.flit.sdist] | ||
| exclude = ["msgraph/generated/kiota-dom-export.txt"] |
Draft
6 tasks
Author
|
I am not a python expert, so I don't know if Copilot's suggestions make sense. Please advise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kiota-dom-export.txt is not needed at runtime and is a very large file (~32MB), contributing to a bloated package.
Fixes #1287
@lramosvea Please review. Note that I hadn't originally created this PR, because I was under the impression that this repository's content was auto-generated as I saw recent PRs from a bot updating these files.
I also wasn't sure if this was a chore or build or something else - let me know if you want it changed.