Skip to content

🔊 add default logging - #356

Open
ianardee wants to merge 1 commit into
mainfrom
logging
Open

ianardee wants to merge 1 commit into
mainfrom
logging

Conversation

@ianardee

@ianardee ianardee commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Description

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Logging can expose credentials in rejected URLs and sensitive document contents in DEBUG responses.

Review effort: Balanced
Findings: 2 High severity

Open (2)
What changed in this PR

Adds logging to the V2 SDK client and HTTP layer for request and polling diagnostics.

Changes:

  • Adds INFO logs for client operations and searches.
  • Adds DEBUG logs for polling, HTTP requests, and response bodies.
  • Renames the private polling helper to pollForResult.
File Description
src/​main/​java/​com/​mindee/​v2/​MindeeClient.java Logs client operations and polling progress; renames polling helper.
src/​main/​java/​com/​mindee/​v2/​http/​MindeeHttpApiV2.java Logs HTTP requests, searches, and response bodies.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/main/java/com/mindee/v2/MindeeClient.java
Comment thread src/main/java/com/mindee/v2/http/MindeeHttpApiV2.java

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants