Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Logging can expose credentials in rejected URLs and sensitive document contents in DEBUG responses.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds logging to the V2 SDK client and HTTP layer for request and polling diagnostics.
Changes:
- Adds INFO logs for client operations and searches.
- Adds DEBUG logs for polling, HTTP requests, and response bodies.
- Renames the private polling helper to
pollForResult.
| File | Description |
|---|---|
src/main/java/com/mindee/v2/MindeeClient.java |
Logs client operations and polling progress; renames polling helper. |
src/main/java/com/mindee/v2/http/MindeeHttpApiV2.java |
Logs HTTP requests, searches, and response bodies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Types of changes