Skip to content

Fix unterminated warning message that breaks gotestsum -> junit parsing#6334

Merged
evankanderson merged 1 commit intomindersec:mainfrom
evankanderson:fix-test-breaking-output
Apr 11, 2026
Merged

Fix unterminated warning message that breaks gotestsum -> junit parsing#6334
evankanderson merged 1 commit intomindersec:mainfrom
evankanderson:fix-test-breaking-output

Conversation

@evankanderson
Copy link
Copy Markdown
Member

Summary

The HTML error summary often erroneously reports that TestGetGrpcConnection and some subset of tests have failed due to corrupted output from the terminal:

=== RUN   TestGetGrpcConnection
=== RUN   TestGetGrpcConnection/If_the_token_is_provided,_create_connection_without_calling_server
=== RUN   TestGetGrpcConnection/With_token,_don't_dial_or_handshake_endpoint
=== RUN   TestGetGrpcConnection/Connect_and_get_token_from_GRPC_handshake
=== RUN   TestGetGrpcConnection/Localhost_GRPC_auto-discovery
=== RUN   TestGetGrpcConnection/GRPC_auto-discovery_with_insecure_external_host
=== RUN   TestGetGrpcConnection/Defaults_connect_to_legacy_endpoint
Unable to fetch WWW-Authenticate header (rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp 127.0.0.1:35443: connect: connection refused"), falling back on static configuration--- PASS: TestGetGrpcConnection (0.02s)
    --- PASS: TestGetGrpcConnection/If_the_token_is_provided,_create_connection_without_calling_server (0.00s)
    --- PASS: TestGetGrpcConnection/With_token,_don't_dial_or_handshake_endpoint (0.00s)
    --- PASS: TestGetGrpcConnection/Connect_and_get_token_from_GRPC_handshake (0.00s)
    --- PASS: TestGetGrpcConnection/Localhost_GRPC_auto-discovery (0.01s)
    --- PASS: TestGetGrpcConnection/GRPC_auto-discovery_with_insecure_external_host (0.00s)
    --- PASS: TestGetGrpcConnection/Defaults_connect_to_legacy_endpoint (0.00s)

Testing

Manual / eyeball testing

@evankanderson evankanderson requested a review from a team as a code owner April 10, 2026 16:17
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 59.314%. remained the same — evankanderson:fix-test-breaking-output into mindersec:main

@evankanderson evankanderson merged commit fc15dc7 into mindersec:main Apr 11, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants