Repository navigation
Move to FAPI lifecycle events to fix #25, other improvements - #26
Closed
MulverineX wants to merge 2 commits into
Closed
MulverineX wants to merge 2 commits into
MulverineX wants to merge 2 commits into
Conversation
Owner
|
I'm not syre how you expect me to merge or even review this PR? This does much more than fixing #25 with unrelated refactors and behavior changes, and all in a single commit. |
Contributor
Author
|
Fleshed out the PR description, apologies, was in a bit of a rush when I first opened the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#> Descriptive text hereas represented here https://github.com/misode/packtest#example)debug functionof a normal mcfunction doesn't work inside a test mcfunction #25 by moving to FAPI lifecycle events that have the full context needed that was missingCompletableFuturewiring is no longer needed because we can now useBlockableEventLoop#execute