Repository navigation
Fix #25 - #27
Closed
MulverineX wants to merge 1 commit into
Closed
Fix #25#27MulverineX wants to merge 1 commit into
MulverineX wants to merge 1 commit into
Conversation
misode
reviewed
Oct 8, 2026
Comment on lines
-25
to
+21
| public class PackTestLibrary implements PreparableReloadListener { | ||
| public class PackTestLibrary { |
Owner
There was a problem hiding this comment.
[PreparableReloadListener] I intend on attempting this soon
Do you realize that it was already using this, and your PR would switch away from using that?
| .withLevel(helper.getLevel()) | ||
| .withPosition(helper.absoluteVec(Vec3.ZERO)) | ||
| .withSuppressedOutput(); | ||
| .withSource(SILENT_SOURCE); |
Owner
There was a problem hiding this comment.
What issue is this intended to solve? Why did withSuppressedOutput not work?
misode
reviewed
Oct 8, 2026
| public class PackTestLibrary { | ||
| private static final FileToIdConverter LISTER = new FileToIdConverter("test", ".mcfunction"); | ||
|
|
||
| private static final Map<Identifier, PackTestFunction> LOADED = new HashMap<>(); |
Owner
There was a problem hiding this comment.
A static map of loaded functions is a really bad idea. Tests are already stored in the registry.
Contributor
Author
|
Turns out this is an upstream bug, I was working on addressing your concerns on this PR soon but ran into it. https://mojira.dev/MC-279191 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I intend on attempting this soon, but here's what I've got so far just using fabric API lifecycle events.
LOADEDandgetLoaded()is for a future PR that will add test descriptions to test failure/pass logging. I can take it out of this PR if preferred.