Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports two improvements from Ward:
drop from <slot> [all],mainhand <slot>anduseas a short form ofuse item.Before:
After:
mainhand <slot>does the same asselectslot <slot>, but counts from 0 to 8. Ward started with onlymainhand, because I find 1 to 9 misleading next to how Minecraft numbers slots everywhere else (hotbar.0tohotbar.8). Ward later addedselectslotfor compatibility with packtest, and this PR addsmainhandhere so both commands exist in both mods. I personally think it would be best to deprecateselectslotin favour ofmainhand, since its numbering is closer to what people expect in commands. What do you think?